@BillionClaw is attempting to deploy a commit to the LobeHub OSS Team on Vercel.

A member of the Team first needs to authorize it.

@tjx666 - This is an image generation fix (preserve resolution when changing aspect ratio). Please take a look.

@BillionClaw plz check codex review

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.76%. Comparing base (926de07) to head (6ea05a4).
⚠️ Report is 6 commits behind head on canary.

@@           Coverage Diff            @@
##           canary   #13324    +/-   ##
========================================
  Coverage   66.76%   66.76%            
========================================
  Files        1889     1888     -1     
  Lines      151446   151439     -7     
  Branches    14506    15220   +714     
========================================
+ Hits       101112   101115     +3     
+ Misses      50222    50212    -10     
  Partials      112      112            

When can it be processed? Version 2.1.48 is still not functioning properly. @tjx666 @BillionClaw

Hi @BillionClaw, two things to address before merge:

1. Please add a regression test. src/store/image/slices/generationConfig/action.test.ts already has an Aspect Ratio Setting describe block — add a case there that seeds parameters.resolution (e.g. '4K') with a schema exposing a resolution enum, calls setAspectRatio('16:9'), and asserts the resolution is preserved. Otherwise this bug can silently regress.

2. Validate the preserved value against the schema's enum. The current patch unconditionally copies parameters.resolution into newParams. If the (current or later-applied) parametersSchema.resolution.enum doesn't contain the previous value, we end up carrying an invalid value forward. Please check membership in parametersSchema.resolution.enum before copying, and fall back to the schema default (or drop the field) when it's not a valid option.

Addressed Review Feedback

Thanks for the review @tjx666. I've addressed both comments:

1. Added Regression Test ✅

Added 3 new test cases in src/store/image/slices/generationConfig/action.test.ts under the Aspect Ratio Setting describe block:

• should preserve resolution when changing aspect ratio for models with resolution enum — verifies 4K resolution is preserved when schema has resolution enum
• should strip resolution when new schema does not support the current resolution value — verifies resolution is stripped if not in new schema's enum
• should strip resolution when schema has no resolution enum — verifies resolution is stripped when schema has no resolution support

2. Added Enum Validation ✅

Updated setAspectRatio in action.ts to validate the preserved resolution against the schema's enum:

// Preserve resolution if it exists in current parameters (models like nanoBanana2 use resolution enum)
// Only preserve if the new schema's resolution enum contains the current value
if (
  'resolution' in parameters &&
  parameters.resolution !== undefined &&
  parametersSchema?.resolution?.enum &&
  parametersSchema.resolution.enum.includes(parameters.resolution)
) {
  newParams.resolution = parameters.resolution;
} else if (
  'resolution' in parameters &&
  parameters.resolution !== undefined &&
  ( !parametersSchema?.resolution?.enum ||
    !parametersSchema.resolution.enum.includes(parameters.resolution))
) {
  // Resolution value is not valid for new schema - strip it
  delete newParams.resolution;
}

The implementation now:

• ✅ Preserves resolution when the new schema supports the same resolution enum value
• ✅ Strips resolution when the new schema's enum doesn't include the current value
• ✅ Strips resolution when the new schema has no resolution enum at all

I've pushed the changes to my fork at Mati0kez/lobehub:canary and created a new PR to supersede this one since I don't have write access to the original branch.

Test comment from API

The fix has been implemented with regression tests. It's currently waiting for Vercel deployment authorization from a LobeHub OSS Team member.

I'll get the CLA signed — will follow up once it's done.

❤️ Great PR @BillionClaw ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.