Skip to content

🔨 chore: temporarily disable notification triggers#13314

Merged
tjx666 merged 1 commit into
canaryfrom
chore/disable-notification-triggers
Mar 26, 2026
Merged

🔨 chore: temporarily disable notification triggers#13314
tjx666 merged 1 commit into
canaryfrom
chore/disable-notification-triggers

Conversation

@tjx666

@tjx666 tjx666 commented Mar 26, 2026

Copy link
Copy Markdown
Member

💻 Change Type

  • 🔨 chore

🔗 Related Issue

Related to #13301

🔀 Description of Change

Comment out notification trigger call sites (notifyImageCompleted and notifyVideoCompleted) until the notification UI is polished. The function implementations remain intact in the cloud override — only the invocations are disabled.

🧪 How to Test

  • No tests needed

@vercel

vercel Bot commented Mar 26, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Ready Ready Preview, Comment Mar 26, 2026 3:30pm

Request Review

@lobehubbot

lobehubbot commented Mar 26, 2026

Copy link
Copy Markdown
Member

@nekomeowww - This is a backend chore disabling notification triggers for image/video generation. Please take a look.

sourcery-ai[bot]
sourcery-ai Bot reviewed Mar 26, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@codecov

codecov Bot commented Mar 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.76%. Comparing base (926de07) to head (b7c4399).
⚠️ Report is 1 commits behind head on canary.

Additional details and impacted files 
@@            Coverage Diff            @@
##           canary   #13314     +/-   ##
=========================================
  Coverage   66.76%   66.76%             
=========================================
  Files        1889     1888      -1     
  Lines      151446   151436     -10     
  Branches    14506    17263   +2757     
=========================================
- Hits       101112   101111      -1     
+ Misses      50222    50213      -9     
  Partials      112      112
Flag Coverage Δ
app 58.20% <ø> (+<0.01%) ⬆️
database 96.64% <ø> (ø)
packages/agent-runtime 89.61% <ø> (ø)
packages/context-engine 83.22% <ø> (ø)
packages/conversation-flow 92.36% <ø> (ø)
packages/file-loaders 87.02% <ø> (ø)
packages/memory-user-memory 66.68% <ø> (ø)
packages/model-bank 99.85% <ø> (ø)
packages/model-runtime 84.48% <ø> (ø)
packages/prompts 67.76% <ø> (ø)
packages/python-interpreter 92.90% <ø> (ø)
packages/ssrf-safe-fetch 0.00% <ø> (ø)
packages/utils 90.41% <ø> (ø)
packages/web-crawler 88.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 66.07% <ø> (ø)
Services 49.56% <ø> (ø)
Server 67.37% <ø> (+0.01%) ⬆️
Libs 51.06% <ø> (ø)
Utils 91.01% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tjx666 tjx666 merged commit edc8920 into canary Mar 26, 2026
31 checks passed
@tjx666 tjx666 deleted the chore/disable-notification-triggers branch March 26, 2026 15:35
@lobehubbot

lobehubbot commented Mar 26, 2026

Copy link
Copy Markdown
Member

❤️ Great PR @tjx666 ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tjx666 @lobehubbot