Skip to content

✨ feat: add notification system (temporarily disabled)#13301

Merged
tjx666 merged 5 commits into
canaryfrom
feat/notification-system
Mar 26, 2026
Merged

✨ feat: add notification system (temporarily disabled)#13301
tjx666 merged 5 commits into
canaryfrom
feat/notification-system

Conversation

@tjx666

@tjx666 tjx666 commented Mar 26, 2026

Copy link
Copy Markdown
Member

πŸ’» Change Type

  • πŸ”¨ chore

πŸ”— Related Issue

πŸ”€ Description of Change

Temporarily disable notification UI until it is polished enough for release:

  • Comment out notification settings tab in useCategory.tsx

πŸ§ͺ How to Test

  • Verify notification settings tab does not appear in settings sidebar

sourcery-ai[bot]
sourcery-ai Bot reviewed Mar 26, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @tjx666, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@vercel

vercel Bot commented Mar 26, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
lobehub Ready Ready Preview, Comment Mar 26, 2026 1:13pm

Request Review

@lobehubbot

lobehubbot commented Mar 26, 2026

Copy link
Copy Markdown
Member

@ONLY-yours @nekomeowww - This involves notification UI (settings, inbox drawer) and backend (database model, TRPC router). Please coordinate.

@codecov

codecov Bot commented Mar 26, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.85714% with 9 lines in your changes missing coverage. Please review.
βœ… Project coverage is 66.69%. Comparing base (d2a16d0) to head (74fb5e4).
⚠️ Report is 3 commits behind head on canary.

Additional details and impacted files 
@@            Coverage Diff            @@
##           canary   #13301     +/-   ##
=========================================
  Coverage   66.69%   66.69%             
=========================================
  Files        1885     1887      +2     
  Lines      150971   150999     +28     
  Branches    17231    14483   -2748     
=========================================
+ Hits       100686   100705     +19     
- Misses      50173    50182      +9     
  Partials      112      112
Flag Coverage Ξ”
app 58.06% <67.85%> (+<0.01%) ⬆️
database 96.64% <ΓΈ> (ΓΈ)
packages/agent-runtime 89.61% <ΓΈ> (ΓΈ)
packages/context-engine 83.22% <ΓΈ> (ΓΈ)
packages/conversation-flow 92.36% <ΓΈ> (ΓΈ)
packages/file-loaders 87.02% <ΓΈ> (ΓΈ)
packages/memory-user-memory 66.68% <ΓΈ> (ΓΈ)
packages/model-bank 99.85% <ΓΈ> (ΓΈ)
packages/model-runtime 84.48% <ΓΈ> (ΓΈ)
packages/prompts 67.76% <ΓΈ> (ΓΈ)
packages/python-interpreter 92.90% <ΓΈ> (ΓΈ)
packages/ssrf-safe-fetch 0.00% <ΓΈ> (ΓΈ)
packages/utils 90.41% <ΓΈ> (ΓΈ)
packages/web-crawler 88.82% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Ξ”
Store 66.07% <100.00%> (+<0.01%) ⬆️
Services 49.56% <ΓΈ> (ΓΈ)
Server 67.36% <11.11%> (-0.02%) ⬇️
Libs 45.46% <ΓΈ> (ΓΈ)
Utils 91.01% <ΓΈ> (ΓΈ)
πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-code-quality[bot]
github-code-quality Bot found potential problems Mar 26, 2026
View reviewed changes
Comment thread src/routes/(main)/home/_layout/Header/components/InboxButton.tsx Fixed
Comment thread src/routes/(main)/home/_layout/Header/components/InboxButton.tsx Fixed
Comment thread src/routes/(main)/home/_layout/Header/components/InboxButton.tsx Fixed
Comment thread src/routes/(main)/home/_layout/Header/components/InboxButton.tsx Fixed
Comment thread src/routes/(main)/home/_layout/Header/components/InboxButton.tsx Fixed
Comment thread src/routes/(main)/home/_layout/Header/components/InboxButton.tsx Fixed
@tjx666 tjx666 changed the title πŸ”¨ chore: temporarily disable notification UI ✨ feat: add notification system (temporarily disabled) Mar 26, 2026
@tjx666 tjx666 force-pushed the feat/notification-system branch from 0ad199f to dc28f0b Compare March 26, 2026 12:11
@tjx666 tjx666 merged commit 9f36fe9 into canary Mar 26, 2026
34 checks passed
@tjx666 tjx666 deleted the feat/notification-system branch March 26, 2026 13:16
@lobehubbot

lobehubbot commented Mar 26, 2026

Copy link
Copy Markdown
Member

❀️ Great PR @tjx666 ❀️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

@tjx666 tjx666 mentioned this pull request Mar 26, 2026
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

+1 more reviewer

@github-code-quality github-code-quality[bot] github-code-quality[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tjx666 @lobehubbot