🐛 fix: fixed the onboarding crash problem#11905
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Reviewer's guide (collapsed on small PRs)Reviewer's GuideDisables the info tag display in the ModelSelect list item rendering to prevent an onboarding crash related to that tag’s behavior. Class diagram for ModelSelect and ModelItemRender prop changeclassDiagram
class ModelSelect {
+renderModelItem(data)
}
class ModelItemRender {
+displayName string
+id string
+showInfoTag boolean
+ability1
+ability2
+render()
}
ModelSelect --> ModelItemRender : renders
%% Before: ModelSelect passed showInfoTag implicitly (true by default)
class ModelSelectBefore {
+renderModelItem(data)
}
class ModelItemRenderBefore {
+displayName string
+id string
+showInfoTag boolean
+ability1
+ability2
+render()
}
ModelSelectBefore --> ModelItemRenderBefore : showInfoTag (default true)
ModelSelect --> ModelItemRender : showInfoTag=false
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding a brief inline comment explaining why
showInfoTagis explicitly set tofalsehere so future changes to the onboarding flow don’t accidentally re-enable the crashing behavior. - If the crash is specific to certain model items or onboarding state, you may want to gate
showInfoTagbased on that condition rather than disabling it for all items rendered by this component.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a brief inline comment explaining why `showInfoTag` is explicitly set to `false` here so future changes to the onboarding flow don’t accidentally re-enable the crashing behavior.
- If the crash is specific to certain model items or onboarding state, you may want to gate `showInfoTag` based on that condition rather than disabling it for all items rendered by this component.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
❤️ Great PR @ONLY-yours ❤️ The growth of the project is inseparable from user feedback and contribution, thanks for your contribution! If you are interested in the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing AI newsletters around the world.
Original Content❤️ Great PR @ONLY-yours ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
### [Version 2.0.3](v2.0.2...v2.0.3) <sup>Released on **2026-01-27**</sup> #### 🐛 Bug Fixes - **misc**: Fixed compressed group message & open the switch config to control compression config enabled, fixed the onboarding crash problem. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: Fixed compressed group message & open the switch config to control compression config enabled, closes [#11901](#11901) ([dc51838](dc51838)) * **misc**: Fixed the onboarding crash problem, closes [#11905](#11905) ([439e4ee](439e4ee)) </details> <div align="right"> [](#readme-top) </div>
|
🎉 This PR is included in version 2.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Regression of lobehub#11905 - fix was reverted during base-ui migration (lobehub#12587) Changed showInfoTag (implicit true) back to showInfoTag={false} (explicit false) to prevent React Error lobehub#185 when clicking model selection dropdown in onboarding. File: src/features/ModelSelect/index.tsx Line: 131
PR lobehub#12587 inadvertently reverted the fix from lobehub#11905 by changing showInfoTag={false} back to showInfoTag (implicit true). This causes React Error lobehub#185 when clicking model selection dropdown during onboarding. Restores showInfoTag={false} to prevent the crash. Fixes lobehub#12817
PR lobehub#12587 inadvertently reverted the fix from lobehub#11905. This causes React Error lobehub#185 when clicking model selection dropdown. Fixes lobehub#12817
PR lobehub#12587 inadvertently reverted the fix from lobehub#11905. This causes React Error lobehub#185 when clicking model selection dropdown. Fixes lobehub#12817
💻 Change Type
🔗 Related Issue
🔀 Description of Change
🧪 How to Test
📸 Screenshots / Videos
📝 Additional Information
Summary by Sourcery
Bug Fixes: