Skip to content

🐛 fix: fixed the onboarding crash problem#11905

Merged
ONLY-yours merged 1 commit into
mainfrom
fix/onboardingCrash
Jan 27, 2026
Merged

🐛 fix: fixed the onboarding crash problem#11905
ONLY-yours merged 1 commit into
mainfrom
fix/onboardingCrash

Conversation

@ONLY-yours

@ONLY-yours ONLY-yours commented Jan 27, 2026

Copy link
Copy Markdown
Member

💻 Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • ✅ test
  • 📝 docs
  • 🔨 chore

🔗 Related Issue

🔀 Description of Change

🧪 How to Test

  • Tested locally
  • Added/updated tests
  • No tests needed

📸 Screenshots / Videos

Before After
... ...

📝 Additional Information

Summary by Sourcery

Bug Fixes:

  • Stop onboarding from crashing by turning off the info tag rendering for model items in the model select UI.

@vercel

vercel Bot commented Jan 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
lobehub Building Building Preview, Comment Jan 27, 2026 1:04pm

Request Review

@sourcery-ai

sourcery-ai Bot commented Jan 27, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Disables the info tag display in the ModelSelect list item rendering to prevent an onboarding crash related to that tag’s behavior.

Class diagram for ModelSelect and ModelItemRender prop change

classDiagram
  class ModelSelect {
    +renderModelItem(data)
  }

  class ModelItemRender {
    +displayName string
    +id string
    +showInfoTag boolean
    +ability1
    +ability2
    +render()
  }

  ModelSelect --> ModelItemRender : renders

  %% Before: ModelSelect passed showInfoTag implicitly (true by default)
  class ModelSelectBefore {
    +renderModelItem(data)
  }

  class ModelItemRenderBefore {
    +displayName string
    +id string
    +showInfoTag boolean
    +ability1
    +ability2
    +render()
  }

  ModelSelectBefore --> ModelItemRenderBefore : showInfoTag (default true)
  ModelSelect --> ModelItemRender : showInfoTag=false
Loading

File-Level Changes

Change Details Files
Disable the info tag for rendered model items in ModelSelect to avoid a crash during onboarding.
  • Update ModelItemRender usage to explicitly pass showInfoTag as false instead of relying on the default truthy prop
  • Ensure abilities from the model data are still spread into ModelItemRender unchanged
src/features/ModelSelect/index.tsx

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@gru-agent

gru-agent Bot commented Jan 27, 2026

Copy link
Copy Markdown
Contributor

TestGru Assignment

Summary

Link CommitId Status Reason
Detail a849e55 🚫 Skipped No files need to be tested {"src/features/ModelSelect/index.tsx":"File path does not match include patterns."}

History Assignment

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider adding a brief inline comment explaining why showInfoTag is explicitly set to false here so future changes to the onboarding flow don’t accidentally re-enable the crashing behavior.
  • If the crash is specific to certain model items or onboarding state, you may want to gate showInfoTag based on that condition rather than disabling it for all items rendered by this component.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider adding a brief inline comment explaining why `showInfoTag` is explicitly set to `false` here so future changes to the onboarding flow don’t accidentally re-enable the crashing behavior.
- If the crash is specific to certain model items or onboarding state, you may want to gate `showInfoTag` based on that condition rather than disabling it for all items rendered by this component.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ONLY-yours ONLY-yours merged commit 439e4ee into main Jan 27, 2026
14 of 15 checks passed
@ONLY-yours ONLY-yours deleted the fix/onboardingCrash branch January 27, 2026 13:05
@lobehubbot

lobehubbot commented Jan 27, 2026

Copy link
Copy Markdown
Member

❤️ Great PR @ONLY-yours ❤️

The growth of the project is inseparable from user feedback and contribution, thanks for your contribution! If you are interested in the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing AI newsletters around the world.


This comment was translated by Claude.

Original Content

❤️ Great PR @ONLY-yours ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

lobehubbot pushed a commit that referenced this pull request Jan 27, 2026
### [Version 2.0.3](v2.0.2...v2.0.3)
<sup>Released on **2026-01-27**</sup>

#### 🐛 Bug Fixes

- **misc**: Fixed compressed group message & open the switch config to control compression config enabled, fixed the onboarding crash problem.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fixed compressed group message & open the switch config to control compression config enabled, closes [#11901](#11901) ([dc51838](dc51838))
* **misc**: Fixed the onboarding crash problem, closes [#11905](#11905) ([439e4ee](439e4ee))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot

Copy link
Copy Markdown
Member

🎉 This PR is included in version 2.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

furkankoykiran added a commit to furkankoykiran/lobehub that referenced this pull request Mar 8, 2026
Regression of lobehub#11905 - fix was reverted during base-ui migration (lobehub#12587)

Changed showInfoTag (implicit true) back to showInfoTag={false} (explicit false)
to prevent React Error lobehub#185 when clicking model selection dropdown in onboarding.

File: src/features/ModelSelect/index.tsx
Line: 131
1cbyc added a commit to 1cbyc/lobehub that referenced this pull request Mar 8, 2026
PR lobehub#12587 inadvertently reverted the fix from lobehub#11905 by changing
showInfoTag={false} back to showInfoTag (implicit true).

This causes React Error lobehub#185 when clicking model selection dropdown
during onboarding.

Restores showInfoTag={false} to prevent the crash.

Fixes lobehub#12817
1cbyc added a commit to 1cbyc/lobehub that referenced this pull request Mar 8, 2026
PR lobehub#12587 inadvertently reverted the fix from lobehub#11905.
This causes React Error lobehub#185 when clicking model selection dropdown.

Fixes lobehub#12817
1cbyc added a commit to 1cbyc/lobehub that referenced this pull request Mar 8, 2026
PR lobehub#12587 inadvertently reverted the fix from lobehub#11905.
This causes React Error lobehub#185 when clicking model selection dropdown.

Fixes lobehub#12817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants