Skip to content

🐛 fix: resolve server version check issue for desktop app#11834

Merged
arvinxx merged 1 commit into
nextfrom
fix/check-version-issue
Jan 25, 2026
Merged

🐛 fix: resolve server version check issue for desktop app#11834
arvinxx merged 1 commit into
nextfrom
fix/check-version-issue

Conversation

@Innei

@Innei Innei commented Jan 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

  • Fix version check to only run for self-hosted remote server mode (not cloud mode)
  • Get remote server URL from electron store for proper origin detection
  • Remove unnecessary isDesktop parameter from useCheckServerVersion hook

Test Plan

  • Verify version check works correctly in desktop app with self-hosted remote server
  • Verify version check is skipped in cloud storage mode
  • Verify version check is skipped in web app

@Innei
🐛 fix: resolve server version check issue for desktop app
0da00eb 
- Fix version check to only run for self-hosted remote server mode
- Get remote server URL from electron store for proper origin detection
- Remove unnecessary isDesktop parameter from useCheckServerVersion hook
@vercel

vercel Bot commented Jan 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
lobehub Building Building Preview, Comment Jan 25, 2026 6:00pm

Request Review

sourcery-ai[bot]
sourcery-ai Bot reviewed Jan 25, 2026
View reviewed changes

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @Innei, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 25, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jan 25, 2026

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Repo admins can enable using credits for code reviews in their settings.

@gru-agent

gru-agent Bot commented Jan 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

TestGru Assignment

Summary

Link CommitId Status Reason
Detail 0da00eb ✅ Finished

History Assignment

Files

File Pull Request
src/store/global/actions/general.ts ❌ Failed (I failed to setup the environment.)

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

@dosubot dosubot Bot added the 🐛 Bug label Jan 25, 2026
@codecov

codecov Bot commented Jan 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 24.00000% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.69%. Comparing base (14adf99) to head (0da00eb).
⚠️ Report is 9 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next   #11834      +/-   ##
==========================================
- Coverage   73.70%   73.69%   -0.02%     
==========================================
  Files        1214     1214              
  Lines       97939    97961      +22     
  Branches    12706    11097    -1609     
==========================================
+ Hits        72188    72193       +5     
- Misses      25660    25677      +17     
  Partials       91       91
Flag Coverage Δ
app 67.40% <24.00%> (-0.02%) ⬇️
database 85.14% <ø> (ø)
packages/agent-runtime 88.57% <ø> (ø)
packages/context-engine 85.52% <ø> (ø)
packages/conversation-flow 92.32% <ø> (ø)
packages/file-loaders 87.04% <ø> (ø)
packages/memory-user-memory 67.12% <ø> (ø)
packages/model-bank 100.00% <ø> (ø)
packages/model-runtime 86.72% <ø> (ø)
packages/prompts 78.32% <ø> (ø)
packages/python-interpreter 92.90% <ø> (ø)
packages/ssrf-safe-fetch 0.00% <ø> (ø)
packages/utils 93.07% <ø> (ø)
packages/web-crawler 95.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 67.23% <42.85%> (-0.01%) ⬇️
Services 50.17% <16.66%> (-0.14%) ⬇️
Server 68.42% <ø> (ø)
Libs 40.13% <ø> (ø)
Utils 93.82% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arvinxx arvinxx merged commit 0bd2a59 into next Jan 25, 2026
45 of 47 checks passed
@arvinxx arvinxx deleted the fix/check-version-issue branch January 25, 2026 18:21
@lobehubbot

lobehubbot commented Jan 25, 2026

Copy link
Copy Markdown
Member

❤️ Great PR @Innei ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

lobehubbot pushed a commit that referenced this pull request Jan 25, 2026
@semantic-release-bot
🔖 chore(release): v2.0.0-next.379 [skip ci]
d4d3f32 
## [Version&nbsp;2.0.0-next.379](v2.0.0-next.378...v2.0.0-next.379)
<sup>Released on **2026-01-25**</sup>

#### ✨ Features

- **utils**: Added `trimBasedOnBatchProbe` for truncating without compromising structured data.

#### 🐛 Bug Fixes

- **desktop**: Prevent duplicate IPC handler registration from dynamic imports.
- **misc**: Fix update memory tools, resolve server version check issue for desktop app, slove the descktop use offical endpoint mcp not use stdio.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's improved

* **utils**: Added `trimBasedOnBatchProbe` for truncating without compromising structured data, closes [#11836](#11836) ([6dac3d1](6dac3d1))

#### What's fixed

* **desktop**: Prevent duplicate IPC handler registration from dynamic imports, closes [#11827](#11827) ([c3fd2dc](c3fd2dc))
* **misc**: Fix update memory tools, closes [#11831](#11831) ([cfc03dd](cfc03dd))
* **misc**: Resolve server version check issue for desktop app, closes [#11834](#11834) ([0bd2a59](0bd2a59))
* **misc**: Slove the descktop use offical endpoint mcp not use stdio, closes [#11813](#11813) ([370bf16](370bf16))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot

lobehubbot commented Jan 25, 2026

Copy link
Copy Markdown
Member

🎉 This PR is included in version 2.0.0-next.379 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

No one assigned

Labels

🐛 Bug released on @next size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Innei @lobehubbot @arvinxx