Preserve tint.Err attribute key#66
Merged
lmittmann merged 2 commits intolmittmann:mainfrom Jul 10, 2024
Merged
Conversation
We do not always have control over how attribute names are defined. However, it is beneficial to highlight errors in development logs for better visibility.
33ce023 to
2f41f32
Compare
tint.Err attribute key
Owner
|
thank you for the improvement |
Contributor
Author
|
Thank you so much for your library, it's absolutely awesome!✨ |
abs3ntdev
added a commit
to abs3ntdev/gspot
that referenced
this pull request
Jul 11, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/lmittmann/tint](https://github.com/lmittmann/tint) | require | patch | `v1.0.4` -> `v1.0.5` | --- ### Release Notes <details> <summary>lmittmann/tint (github.com/lmittmann/tint)</summary> ### [`v1.0.5`](https://github.com/lmittmann/tint/releases/tag/v1.0.5) [Compare Source](lmittmann/tint@v1.0.4...v1.0.5) #### What's Changed - Preserve `tint.Err` attribute key by [@​kwargs](https://github.com/kwargs) in lmittmann/tint#66 #### New Contributors - [@​kwargs](https://github.com/kwargs) made their first contribution in lmittmann/tint#66 **Full Changelog**: lmittmann/tint@v1.0.4...v1.0.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=--> Co-authored-by: Renovate Bot <renovate-bot@gitea.com> Reviewed-on: https://git.asdf.cafe/abs3nt/gspot/pulls/19
renovate bot
referenced
this pull request
in jippi/dottie
Jul 12, 2024
#63) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/lmittmann/tint](https://togithub.com/lmittmann/tint) | `v1.0.4` -> `v1.0.5` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>lmittmann/tint (github.com/lmittmann/tint)</summary> ### [`v1.0.5`](https://togithub.com/lmittmann/tint/releases/tag/v1.0.5) [Compare Source](https://togithub.com/lmittmann/tint/compare/v1.0.4...v1.0.5) #### What's Changed - Preserve `tint.Err` attribute key by [@​kwargs](https://togithub.com/kwargs) in [https://github.com/lmittmann/tint/pull/66](https://togithub.com/lmittmann/tint/pull/66) #### New Contributors - [@​kwargs](https://togithub.com/kwargs) made their first contribution in [https://github.com/lmittmann/tint/pull/66](https://togithub.com/lmittmann/tint/pull/66) **Full Changelog**: lmittmann/tint@v1.0.4...v1.0.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "* */8 * * *" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/jippi/dottie). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We do not always have control over how attribute names are defined. However, it is beneficial to highlight errors in development logs for better visibility.
For example, we heavily rely on Temporal, and modifying attribute names in that context appears inconsistent.