[sanitizers] Ensure we build LLVM's libunwind with the sanitizers#96
Merged
vitalybuka merged 1 commit intollvm:mainfrom Jan 11, 2024
ldionne:review/sanitizers-add-libunwind
Merged
[sanitizers] Ensure we build LLVM's libunwind with the sanitizers#96vitalybuka merged 1 commit intollvm:mainfrom ldionne:review/sanitizers-add-libunwind
vitalybuka merged 1 commit intollvm:mainfrom
ldionne:review/sanitizers-add-libunwind
Conversation
See llvm/llvm-project#77687 for more details.
vitalybuka
approved these changes
Jan 11, 2024
ye-luo
reviewed
Jan 11, 2024
| cmake \ | ||
| ${cmake_stage2_common_options} \ | ||
| -DLLVM_ENABLE_RUNTIMES='libcxx;libcxxabi' \ | ||
| -DLLVM_ENABLE_RUNTIMES='libcxx;libcxxabi;libunwind' \ |
There was a problem hiding this comment.
How do you guarantee building libunwind completes before libcxxabi needs the library file?
Member
Author
There was a problem hiding this comment.
libunwind is included before libcxxabi in runtimes/CMakeLists.txt, so we will definitely know about the target when we are building libcxxabi. Then Ninja (or Make or w/e) is responsible for honoring target-level dependencies.
vitalybuka
added a commit
that referenced
this pull request
Jan 12, 2024
llvm/llvm-project#77687 enabled libunwind, but not all tests pass with sanitizers. So disable libunwind to investigate.
vitalybuka
added a commit
that referenced
this pull request
Jan 12, 2024
Looks like llvm/llvm-project#77689 fixed the issue. This reverts commit 23cd70e.
vitalybuka
added a commit
that referenced
this pull request
Jan 12, 2024
llvm/llvm-project#77689 is not a fix. This reverts commit 8202ffd.
vitalybuka
added a commit
that referenced
this pull request
Jan 12, 2024
llvm/llvm-project#77689 is not a fix. This reverts commit 8202ffd.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See llvm/llvm-project#77687 for more details.