Skip to content

[lldb] Added Debuginfod tests and fixed a couple issues#92572

Merged
clayborg merged 12 commits intollvm:mainfrom
kevinfrei:debuginfod-tests-curl-dependent
May 22, 2024
Merged

[lldb] Added Debuginfod tests and fixed a couple issues#92572
clayborg merged 12 commits intollvm:mainfrom
kevinfrei:debuginfod-tests-curl-dependent

Conversation

@kevinfrei
Copy link
Contributor

@kevinfrei kevinfrei commented May 17, 2024 •
edited
Loading

Here we go with attempt number five. Again, no changes to the LLDB code diff, which has been reviewed several times.

For the tests, I added a @skipIfCurlSupportMissing annotation so that the Debuginfod mocked server stuff won't run, and I also disabled non-Linux/FreeBSD hosts altogether, as they fail for platform reasons on macOS and Windows. In addition, I updated the process for extracting the GNU BuildID to no create a target, per some feedback on the previous diff.

For reference, previous PR's (landed, backed out after the fact for various reasons) #90622, #87676, #86812, #85693

Kevin Frei added 12 commits May 17, 2024 09:07
Trying to deal with Linux AArch64 test failures :/
8a54497
Reapply "DebugInfoD tests + fixing issues exposed by tests (llvm#85693)"
c87d4bf 
This reverts commit 7fc2fbb.
Switched to using LLDB to get UUID at @clayborg's suggestion
31d72b1
Disable tests on non-x86 Linux platforms, as they appear to fail on A…
bdb6b41 
…Arch64/Arm buildbots
Moved the @skipIf to each test, off of the class itself
76c6600
Added CURL dependency to lit configuration 'stuff'
841db5f
Fixed comments in the tests
afd44bd
Fix stupid formatter issue
84573d5
Updated to respond to (very late) code review feedback
c9113d4
Fixed the script to acquire the UUID without creating a target
84be0d8
Updated tests to not run on Mac/Windows
a732cda
Added LLVM_ENABLE_CURL to the config.h.cmake to work in test's @skipI…
c7adaf7 
…f thing
@kevinfrei kevinfrei marked this pull request as ready for review May 17, 2024 16:31
@kevinfrei kevinfrei requested a review from JDevlieghere as a code owner May 17, 2024 16:31
@kevinfrei
Copy link
Contributor Author

kevinfrei commented May 17, 2024 •
edited
Loading

FYI: The previous diff exposed a bug in some ARM code that @DavidSpicket fixed in #91585, but (for understandable reasons) he didn't want to be left holding the bag on restoring this diff, so I integrated some post-land feedback from @labath and put the diff back up for review.

@clayborg clayborg merged commit e558d21 into llvm:main May 22, 2024
@mysterymath
Copy link
Contributor

mysterymath commented May 22, 2024 •
edited
Loading

This broke the Fuchsia CI builders' LLDB test suite:

https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8747217173107569041/overview

FAIL: LLDB (/b/s/w/ir/x/w/llvm_build/bin/clang-x86_64) :: test_normal_stripped_split_with_dwp (TestDebuginfodDWP.DebugInfodDWPTests.test_normal_stripped_split_with_dwp)
======================================================================
ERROR: test_debuginfod_both_okd_symfiles_from_service (TestDebuginfodDWP.DebugInfodDWPTests.test_debuginfod_both_okd_symfiles_from_service)
   Test behavior with both the only-keep-debug symbols and the dwp symbols
----------------------------------------------------------------------
Error when building test subject.

"/b/s/w/ir/x/w/llvm_build/bin/dwp" -o "a.out.dwp" main.dwo
/bin/sh: 1: /b/s/w/ir/x/w/llvm_build/bin/dwp: not found
make: *** [Makefile.rules:584: a.out.debug] Error 127
make: Leaving directory '/b/s/w/ir/x/w/llvm_build/lldb-test-build.noindex/debuginfod/SplitDWARF/TestDebuginfodDWP.test_debuginfod_both_okd_symfiles_from_service'

Test Directory:
/b/s/w/ir/x/w/llvm-llvm-project/lldb/test/API/debuginfod/SplitDWARF

======================================================================
ERROR: test_expr_dwarf (TestSharedLibStrippedSymbols.SharedLibStrippedTestCase.test_expr_dwarf)
   Test that types work when defined in a shared library and forwa/d-declared in the main executable
----------------------------------------------------------------------
Error when building test subject.


...

ifeq "" "YES"
/bin/sh: 1: ifeq: not found
make: *** [Makefile.rules:631: libfoo.so] Error 127
make: Leaving directory '/b/s/w/ir/x/w/llvm_build/lldb-test-build.noindex/lang/c/shared_lib_stripped_symbols/TestSharedLibStrippedSymbols.test_expr_dwarf'

mysterymath added a commit that referenced this pull request May 22, 2024
@mysterymath
Revert "[lldb] Added Debuginfod tests and fixed a couple issues (#92572…
daa63e1 
…)"

This reverts commit e558d21.
@mysterymath mysterymath mentioned this pull request May 22, 2024
Merged
mysterymath added a commit that referenced this pull request May 22, 2024
@mysterymath
Revert "[lldb] Added Debuginfod tests and fixed a couple issues" (#93094
c93a670 
)

Reverts #92572 due to Fuchsia CI breakages (using CLI
tools in tests that weren't necessarily built).
@kevinfrei kevinfrei deleted the debuginfod-tests-curl-dependent branch July 2, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clayborg clayborg clayborg approved these changes

@JDevlieghere JDevlieghere Awaiting requested review from JDevlieghere JDevlieghere is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kevinfrei @mysterymath @clayborg