Compile MSAN/TSAN failing test with -O1#73555
Merged
Conversation
Member
|
@llvm/pr-subscribers-libcxx Author: Eric (EricWF) ChangesThis attempts to fix flakes on the bots where the modified test times out while running under sanitizers. Turning on the optimizer for just this test appears to mostly fix the issue. Full diff: https://github.com/llvm/llvm-project/pull/73555.diff 1 Files Affected:
diff --git a/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp b/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp
index 946c2cfabf02b63..d3d731bbb1029ca 100644
--- a/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp
+++ b/libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp
@@ -9,6 +9,9 @@
// REQUIRES: long_tests
// UNSUPPORTED: GCC-ALWAYS_INLINE-FIXME
+// This test chokes on the sanitizers during CI runs. It appears we can address most of this by simply enabling optimizations.
+// ADDITIONAL_COMPILE_FLAGS: -DFOO
+
// <deque>
// template <class InputIterator>
|
This attempts to fix flakes on the bots where the modified test times out while running under sanitizers. Turning on the optimizer for just this test appears to mostly fix the issue.
83f288b to
3249c11
Compare
ldionne
reviewed
Nov 27, 2023
libcxx/test/std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp
Outdated
Show resolved
Hide resolved
ldionne
approved these changes
Nov 29, 2023
ldionne
added a commit
that referenced
this pull request
Dec 1, 2023
This reverts commit 61aef97, which broke the CI on GCC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to fix flakes on the bots where the modified test times out while running under sanitizers.
Turning on the optimizer for just this test appears to mostly fix the issue.