[lldb][test] Add FindGlobalVariables tests for C++ inline static data members#70641
Merged
Michael137 merged 2 commits intollvm:mainfrom Nov 6, 2023
Merged
Conversation
Member
|
@llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) ChangesTests that LLDB can find inline static data members. Relies on the debug-info change in: #70639 Full diff: https://github.com/llvm/llvm-project/pull/70641.diff 1 Files Affected:
diff --git a/lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py b/lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py
index 530191e8a37ba1b..8944044d5a265c0 100644
--- a/lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py
+++ b/lldb/test/API/lang/cpp/const_static_integral_member/TestConstStaticIntegralMember.py
@@ -113,6 +113,37 @@ def test_class_with_only_const_static(self):
self.expect_expr("ClassWithOnlyConstStatic::member", result_value="3")
+ def check_global_var(self, name: str, expect_type, expect_val):
+ var_list = self.target().FindGlobalVariables(name, lldb.UINT32_MAX)
+ self.assertEqual(len(var_list), 1)
+ varobj = var_list[0]
+ self.assertEqual(varobj.type.name, expect_type)
+ self.assertEqual(varobj.value, expect_val)
+
+ # For debug-info produced by older versions of clang, inline static data members
+ # wouldn't get indexed into the Names accelerator table preventing LLDB from finding
+ # them.
+ @expectedFailureAll(compiler=["clang"], compiler_version=["<", "18.0"])
+ @expectedFailureAll(debug_info=no_match(["dsym"]))
+ def test_inline_static_members(self):
+ self.build()
+ lldbutil.run_to_source_breakpoint(
+ self, "// break here", lldb.SBFileSpec("main.cpp")
+ )
+
+ self.check_global_var("A::int_val", "const int", "1")
+ self.check_global_var("A::int_val_with_address", "const int", "2")
+ self.check_global_var("A::bool_val", "const bool", "true")
+ self.check_global_var("A::enum_val", "Enum", "enum_case2")
+ self.check_global_var("A::enum_bool_val", "EnumBool", "enum_bool_case1")
+ self.check_global_var("A::scoped_enum_val", "ScopedEnum", "scoped_enum_case2")
+
+ self.check_global_var("ClassWithOnlyConstStatic::member", "const int", "3")
+
+ self.check_global_var("ClassWithConstexprs::member", "const int", "2")
+ self.check_global_var("ClassWithConstexprs::enum_val", "Enum", "enum_case2")
+ self.check_global_var("ClassWithConstexprs::scoped_enum_val", "ScopedEnum", "scoped_enum_case2")
+
# With older versions of Clang, LLDB fails to evaluate classes with only
# constexpr members when dsymutil is enabled
@expectedFailureAll(
|
Michael137
commented
Oct 30, 2023
| # wouldn't get indexed into the Names accelerator table preventing LLDB from finding | ||
| # them. | ||
| @expectedFailureAll(compiler=["clang"], compiler_version=["<", "18.0"]) | ||
| @expectedFailureAll(debug_info=no_match(["dsym"])) |
Member
Author
There was a problem hiding this comment.
This is a separate issue to do with how variable DIEs are parsed when debug maps are present. Will fix in a follow-up
|
✅ With the latest revision this PR passed the Python code formatter. |
clayborg
approved these changes
Oct 30, 2023
Collaborator
clayborg
left a comment
There was a problem hiding this comment.
This will be great to get it (this PR and the related one). The tests LGTM.
Michael137
added a commit
to Michael137/llvm-project
that referenced
this pull request
Nov 6, 2023
…tic data members (llvm#70641)" This reverts commit 934c573. We had to revert dependencies of this patch due to test failures on Linux: ``` 4909814 ef3feba ```
This was referenced Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests that LLDB can find inline static data members.
Relies on the debug-info change in: #70639