Reapply "[MC][NFC] Make FeatureKV/SubtargetKV pointers private" (#206234)#206237
Merged
aengelke merged 1 commit intoJun 27, 2026
Conversation
Created using spr 1.3.8-wip
JonathanBrouwer
pushed a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 29, 2026
In LLVM, FeatureKV/SubtargetKV pointers are now private: llvm/llvm-project#206237 This change fixes compiler errors when building rustc with ToT LLVM by using the key() and desc() accessors.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 29, 2026
llvm-wrapper: use accessors for private fields in LLVM 23+ In LLVM, FeatureKV/SubtargetKV pointers are now private: llvm/llvm-project#206237 This change fixes compiler errors when building rustc with ToT LLVM by using the key() and desc() accessors.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 30, 2026
llvm-wrapper: use accessors for private fields in LLVM 23+ In LLVM, FeatureKV/SubtargetKV pointers are now private: llvm/llvm-project#206237 This change fixes compiler errors when building rustc with ToT LLVM by using the key() and desc() accessors.
LouisLu060211
pushed a commit
to LouisLu060211/llvm-project
that referenced
this pull request
Jun 30, 2026
…#206234) (llvm#206237) Fix C++20 build by adding an explicit constructor. This also permits making the fields private. This reapplies llvm#206178. This reverts commit e44103c.
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
Jun 30, 2026
Rollup merge of #158568 - liza371:llvm-23-compat, r=nikic llvm-wrapper: use accessors for private fields in LLVM 23+ In LLVM, FeatureKV/SubtargetKV pointers are now private: llvm/llvm-project#206237 This change fixes compiler errors when building rustc with ToT LLVM by using the key() and desc() accessors.
maarcosrmz
pushed a commit
to maarcosrmz/llvm-project
that referenced
this pull request
Jul 1, 2026
…#206234) (llvm#206237) Fix C++20 build by adding an explicit constructor. This also permits making the fields private. This reapplies llvm#206178. This reverts commit e44103c.
zedddie
pushed a commit
to zedddie/rust
that referenced
this pull request
Jul 2, 2026
In LLVM, FeatureKV/SubtargetKV pointers are now private: llvm/llvm-project#206237 This change fixes compiler errors when building rustc with ToT LLVM by using the key() and desc() accessors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix C++20 build by adding an explicit constructor. This also permits
making the fields private.
This reapplies #206178.
This reverts commit e44103c.