Revert "[WebAssembly] Mark extract.last.active as having invalid cost."#180942
Merged
Revert "[WebAssembly] Mark extract.last.active as having invalid cost."#180942
Conversation
The failures should have been resolved with llvm#180290 (which also added WebAssembly tests). This reverts commit 811fb22.
Member
|
@llvm/pr-subscribers-llvm-analysis @llvm/pr-subscribers-backend-webassembly Author: Benjamin Maxwell (MacDue) ChangesThe failures should have been resolved with #180290 (which also added WebAssembly tests). This reverts commit 811fb22. Full diff: https://github.com/llvm/llvm-project/pull/180942.diff 2 Files Affected:
diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.cpp b/llvm/lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.cpp
index 33498805112c0..f058d734bcb87 100644
--- a/llvm/lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.cpp
+++ b/llvm/lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.cpp
@@ -453,19 +453,6 @@ InstructionCost WebAssemblyTTIImpl::getPartialReductionCost(
return Invalid;
}
-InstructionCost
-WebAssemblyTTIImpl::getIntrinsicInstrCost(const IntrinsicCostAttributes &ICA,
- TTI::TargetCostKind CostKind) const {
- switch (ICA.getID()) {
- case Intrinsic::experimental_vector_extract_last_active:
- // TODO: Remove once the intrinsic can be lowered without crashes.
- return InstructionCost::getInvalid();
- default:
- break;
- }
- return BaseT::getIntrinsicInstrCost(ICA, CostKind);
-}
-
TTI::ReductionShuffle WebAssemblyTTIImpl::getPreferredExpandedReductionShuffle(
const IntrinsicInst *II) const {
diff --git a/llvm/lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.h b/llvm/lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.h
index 924249e051321..9b6de65f17c7f 100644
--- a/llvm/lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.h
+++ b/llvm/lib/Target/WebAssembly/WebAssemblyTargetTransformInfo.h
@@ -98,10 +98,6 @@ class WebAssemblyTTIImpl final : public BasicTTIImplBase<WebAssemblyTTIImpl> {
TTI::TargetCostKind CostKind,
std::optional<FastMathFlags> FMF) const override;
- InstructionCost
- getIntrinsicInstrCost(const IntrinsicCostAttributes &ICA,
- TTI::TargetCostKind CostKind) const override;
-
TTI::ReductionShuffle
getPreferredExpandedReductionShuffle(const IntrinsicInst *II) const override;
|
fhahn
reviewed
Feb 11, 2026
Contributor
fhahn
left a comment
There was a problem hiding this comment.
Thanks for following up on this!
Would be good to have a test case if possible, either checking the cost on webassembly or checking the loop that previously crashes gets vectorized now
Member
Author
|
I've added a basic cost model test 👍 |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/65/builds/29945 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/225/builds/2675 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/builds/46709 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/22565 Here is the relevant piece of the build log for the reference |
Member
Author
|
Reverted for now, as it appears something has changed the CostModel since I updated this PR yesterday. I’ll look into this later. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/54/builds/16832 Here is the relevant piece of the build log for the reference |
Member
Author
|
Probably need to limit the test to WebAssembly, I forgot about the |
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Feb 13, 2026
…having invalid cost."" (#181342) Reverts llvm/llvm-project#180942 Looks like something changed the cost model. Will investigate later.
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/180/builds/32951 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/160/builds/32811 Here is the relevant piece of the build log for the reference |
manasij7479
pushed a commit
to manasij7479/llvm-project
that referenced
this pull request
Feb 18, 2026
…." (llvm#180942) The failures should have been resolved with llvm#180290 (which also added WebAssembly tests). This reverts commit 811fb22.
manasij7479
pushed a commit
to manasij7479/llvm-project
that referenced
this pull request
Feb 18, 2026
…lid cost."" (llvm#181342) Reverts llvm#180942 Looks like something changed the cost model. Will investigate later.
manasij7479
pushed a commit
to manasij7479/llvm-project
that referenced
this pull request
Feb 18, 2026
…." (llvm#181545) The failures should have been resolved with llvm#180290 (which also added WebAssembly tests). This reverts commit llvm@811fb22. --- This is the same as llvm#180942, but with a `lit.local.cfg` added to the CostModel test folder.
HendrikHuebner
pushed a commit
to HendrikHuebner/llvm-project
that referenced
this pull request
Mar 10, 2026
…." (llvm#181545) The failures should have been resolved with llvm#180290 (which also added WebAssembly tests). This reverts commit llvm@811fb22. --- This is the same as llvm#180942, but with a `lit.local.cfg` added to the CostModel test folder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failures should have been resolved with #180290 (which also added WebAssembly tests).
This reverts commit 811fb22.