[lldb] skip the python interactive I/O test on windows#175055
Merged
[lldb] skip the python interactive I/O test on windows#175055
Conversation
Member
|
@llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) ChangesThere is no indication this ever worked on windows. Looking at the error from the CI it closed the interpreter before running any commands. From #174216 Full diff: https://github.com/llvm/llvm-project/pull/175055.diff 2 Files Affected:
diff --git a/lldb/test/API/python_api/file_handle/TestFileHandle.py b/lldb/test/API/python_api/file_handle/TestFileHandle.py
index 707044a3afb0f..b69724ec8db11 100644
--- a/lldb/test/API/python_api/file_handle/TestFileHandle.py
+++ b/lldb/test/API/python_api/file_handle/TestFileHandle.py
@@ -680,6 +680,7 @@ def test_stdout_file(self):
lines = [x for x in f.read().strip().split() if x != "7"]
self.assertEqual(lines, ["foobar"])
+ @skipIfWindows
def test_stdout_file_interactive(self):
"""Ensure when we read stdin from a file, outputs from python goes to the right I/O stream."""
with open(self.in_filename, "w") as f:
diff --git a/lldb/test/Shell/ScriptInterpreter/Python/io.test b/lldb/test/Shell/ScriptInterpreter/Python/io.test
index 25e3de41724e0..1a3ff8dcd4258 100644
--- a/lldb/test/Shell/ScriptInterpreter/Python/io.test
+++ b/lldb/test/Shell/ScriptInterpreter/Python/io.test
@@ -1,3 +1,5 @@
+# UNSUPPORTED: system-windows
+
# RUN: rm -rf %t.stdout %t.stderr
# RUN: cat %s | %lldb --script-language python > %t.stdout 2> %t.stderr
# RUN: cat %t.stdout | FileCheck %s --check-prefix STDOUT
|
Contributor
|
Note lldb-remote-linux-win failed too. Use |
kshitijvp
pushed a commit
to kshitijvp/llvm-project
that referenced
this pull request
Jan 9, 2026
There is no indication this ever worked on windows as this is the first test that checks python interactive console from a file. Looking at the error from the CI, It closed the interpreter before running any python commands. Will reconfirm this when I have access to a windows machine. From llvm#174216
Priyanshu3820
pushed a commit
to Priyanshu3820/llvm-project
that referenced
this pull request
Jan 18, 2026
There is no indication this ever worked on windows as this is the first test that checks python interactive console from a file. Looking at the error from the CI, It closed the interpreter before running any python commands. Will reconfirm this when I have access to a windows machine. From llvm#174216
da-viper
added a commit
to da-viper/llvm-project
that referenced
this pull request
Jan 27, 2026
There is no indication this ever worked on windows as this is the first test that checks python interactive console from a file. Looking at the error from the CI, It closed the interpreter before running any python commands. Will reconfirm this when I have access to a windows machine. From llvm#174216 (cherry picked from commit 21a1e6e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no indication this ever worked on windows as this is the first test that checks python interactive console from a file.
Looking at the error from the CI, It closed the interpreter before running any python commands.
Will reconfirm this tomorrow when I have access to a windows machine.
Unblocks CI
From #174216