[X86][NewPM] Consistently preserve IR analyses in MF passes#173759
Merged
boomanaiden154 merged 3 commits intomainfrom Dec 29, 2025
Merged
Conversation
Created using spr 1.3.7 [skip ci]
Created using spr 1.3.7
Member
|
@llvm/pr-subscribers-backend-x86 Author: Aiden Grossman (boomanaiden154) ChangesThese three passes were not. Update them to make them consistent with Full diff: https://github.com/llvm/llvm-project/pull/173759.diff 3 Files Affected:
diff --git a/llvm/lib/Target/X86/X86AvoidTrailingCall.cpp b/llvm/lib/Target/X86/X86AvoidTrailingCall.cpp
index ebd4284f0f37d..67003dcbcf1d2 100644
--- a/llvm/lib/Target/X86/X86AvoidTrailingCall.cpp
+++ b/llvm/lib/Target/X86/X86AvoidTrailingCall.cpp
@@ -149,7 +149,5 @@ X86AvoidTrailingCallPass::run(MachineFunction &MF,
if (!Changed)
return PreservedAnalyses::all();
- PreservedAnalyses PA = PreservedAnalyses::none();
- PA.preserveSet<CFGAnalyses>();
- return PA;
+ return getMachineFunctionPassPreservedAnalyses().preserveSet<CFGAnalyses>();
}
diff --git a/llvm/lib/Target/X86/X86DynAllocaExpander.cpp b/llvm/lib/Target/X86/X86DynAllocaExpander.cpp
index 10f46f71bbbbd..bb4301c11c270 100644
--- a/llvm/lib/Target/X86/X86DynAllocaExpander.cpp
+++ b/llvm/lib/Target/X86/X86DynAllocaExpander.cpp
@@ -319,7 +319,5 @@ X86DynAllocaExpanderPass::run(MachineFunction &MF,
if (!Changed)
return PreservedAnalyses::all();
- PreservedAnalyses PA = PreservedAnalyses::none();
- PA.preserveSet<CFGAnalyses>();
- return PA;
+ return getMachineFunctionPassPreservedAnalyses().preserveSet<CFGAnalyses>();
}
diff --git a/llvm/lib/Target/X86/X86FloatingPoint.cpp b/llvm/lib/Target/X86/X86FloatingPoint.cpp
index 6af2050d8b9d0..8b89058c31201 100644
--- a/llvm/lib/Target/X86/X86FloatingPoint.cpp
+++ b/llvm/lib/Target/X86/X86FloatingPoint.cpp
@@ -1847,7 +1847,5 @@ X86FPStackifierPass::run(MachineFunction &MF,
bool Changed = Impl.run(MF, Bundles);
if (!Changed)
return PreservedAnalyses::all();
- PreservedAnalyses PA = PreservedAnalyses::none();
- PA.preserveSet<CFGAnalyses>();
- return PA;
+ return getMachineFunctionPassPreservedAnalyses().preserveSet<CFGAnalyses>();
}
|
boomanaiden154
added a commit
to boomanaiden154/llvm-project
that referenced
this pull request
Dec 28, 2025
These three passes were not. Update them to make them consistent with the rest of the MF passes. Pull Request: llvm#173759
paperchalice
approved these changes
Dec 29, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/18434 Here is the relevant piece of the build log for the reference |
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These three passes were not. Update them to make them consistent with
the rest of the MF passes.