[flang][OpenMP] Allow INIT clause on DEPOBJ, add depinfo-modifier#173056
Merged
[flang][OpenMP] Allow INIT clause on DEPOBJ, add depinfo-modifier#173056
Conversation
Member
|
@llvm/pr-subscribers-flang-semantics @llvm/pr-subscribers-flang-openmp Author: Krzysztof Parzyszek (kparzysz) ChangesFull diff: https://github.com/llvm/llvm-project/pull/173056.diff 11 Files Affected:
diff --git a/flang/include/flang/Parser/dump-parse-tree.h b/flang/include/flang/Parser/dump-parse-tree.h
index 8527f0c545177..466cec9003038 100644
--- a/flang/include/flang/Parser/dump-parse-tree.h
+++ b/flang/include/flang/Parser/dump-parse-tree.h
@@ -580,6 +580,7 @@ class ParseTreeDumper {
NODE(OmpDependClause::TaskDep, Modifier)
NODE(parser, OmpDependenceType)
NODE_ENUM(OmpDependenceType, Value)
+ NODE(parser, OmpDepinfoModifier)
NODE(parser, OmpDestroyClause)
NODE(parser, OmpDetachClause)
NODE(parser, OmpDeviceClause)
diff --git a/flang/include/flang/Parser/parse-tree.h b/flang/include/flang/Parser/parse-tree.h
index a31eb542a50d0..6ac195f9357a5 100644
--- a/flang/include/flang/Parser/parse-tree.h
+++ b/flang/include/flang/Parser/parse-tree.h
@@ -3970,6 +3970,18 @@ struct OmpDependenceType {
WRAPPER_CLASS_BOILERPLATE(OmpDependenceType, Value);
};
+// Ref: [6.0:180-181]
+//
+// depinfo-modifier -> // since 6.0
+// keyword (locator-list-item)
+// keyword ->
+// IN | INOUT | INOUTSET | MUTEXINOUTSET | OUT // since 6.0
+struct OmpDepinfoModifier {
+ using Value = common::OmpDependenceKind;
+ TUPLE_CLASS_BOILERPLATE(OmpDepinfoModifier);
+ std::tuple<Value, OmpObject> t;
+};
+
// Ref: [5.0:170-176], [5.1:197-205], [5.2:276-277]
//
// device-modifier ->
@@ -4670,6 +4682,19 @@ struct OmpIfClause {
std::tuple<MODIFIERS(), ScalarLogicalExpr> t;
};
+// Ref: [5.1:217-220], [5.2:293-294], [6.0:180-181]
+//
+// init-clause ->
+// INIT ([modifier... :] interop-var) // since 5.1
+// modifier ->
+// prefer-type | interop-type | // since 5.1
+// depinfo-modifier // since 6.0
+struct OmpInitClause {
+ TUPLE_CLASS_BOILERPLATE(OmpInitClause);
+ MODIFIER_BOILERPLATE(OmpPreferType, OmpInteropType, OmpDepinfoModifier);
+ std::tuple<MODIFIERS(), OmpObject> t;
+};
+
// Ref: [5.0:170-176], [5.1:197-205], [5.2:138-139]
//
// in-reduction-clause ->
@@ -5013,20 +5038,6 @@ struct OmpWhenClause {
t;
};
-// REF: [5.1:217-220], [5.2:293-294]
-//
-// init-clause -> INIT ([interop-modifier,] [interop-type,]
-// interop-type: interop-var)
-// interop-modifier: prefer_type(preference-list)
-// interop-type: target, targetsync
-// interop-var: Ompobject
-// There can be at most only two interop-type.
-struct OmpInitClause {
- TUPLE_CLASS_BOILERPLATE(OmpInitClause);
- MODIFIER_BOILERPLATE(OmpPreferType, OmpInteropType);
- std::tuple<MODIFIERS(), OmpObject> t;
-};
-
// REF: [5.1:217-220], [5.2:294]
//
// 14.1.3 use-clause -> USE (interop-var)
diff --git a/flang/include/flang/Semantics/openmp-modifiers.h b/flang/include/flang/Semantics/openmp-modifiers.h
index de76255c7215c..8dcac9b179924 100644
--- a/flang/include/flang/Semantics/openmp-modifiers.h
+++ b/flang/include/flang/Semantics/openmp-modifiers.h
@@ -80,6 +80,7 @@ DECLARE_DESCRIPTOR(parser::OmpCloseModifier);
DECLARE_DESCRIPTOR(parser::OmpContextSelector);
DECLARE_DESCRIPTOR(parser::OmpDeleteModifier);
DECLARE_DESCRIPTOR(parser::OmpDependenceType);
+DECLARE_DESCRIPTOR(parser::OmpDepinfoModifier);
DECLARE_DESCRIPTOR(parser::OmpDeviceModifier);
DECLARE_DESCRIPTOR(parser::OmpDimsModifier);
DECLARE_DESCRIPTOR(parser::OmpDirectiveNameModifier);
diff --git a/flang/lib/Parser/openmp-parsers.cpp b/flang/lib/Parser/openmp-parsers.cpp
index 1f0d1be9adc00..4c8112b3e3983 100644
--- a/flang/lib/Parser/openmp-parsers.cpp
+++ b/flang/lib/Parser/openmp-parsers.cpp
@@ -252,6 +252,23 @@ void OmpDirectiveNameParser::initTokens(std::vector<NameWithId> table[]) const {
}
}
+// --- Common types ---------------------------------------------------
+
+TYPE_PARSER(construct<common::OmpDependenceKind>(
+ "DEPOBJ" >> pure(common::OmpDependenceKind::Depobj) ||
+ "IN"_id >> pure(common::OmpDependenceKind::In) ||
+ "INOUT"_id >> pure(common::OmpDependenceKind::Inout) ||
+ "INOUTSET" >> pure(common::OmpDependenceKind::Inoutset) ||
+ "MUTEXINOUTSET" >> pure(common::OmpDependenceKind::Mutexinoutset) ||
+ "OUT" >> pure(common::OmpDependenceKind::Out)))
+
+TYPE_PARSER(construct<common::OmpMemoryOrderType>(
+ "ACQ_REL" >> pure(common::OmpMemoryOrderType::Acq_Rel) ||
+ "ACQUIRE" >> pure(common::OmpMemoryOrderType::Acquire) ||
+ "RELAXED" >> pure(common::OmpMemoryOrderType::Relaxed) ||
+ "RELEASE" >> pure(common::OmpMemoryOrderType::Release) ||
+ "SEQ_CST" >> pure(common::OmpMemoryOrderType::Seq_Cst)))
+
// --- Modifier helpers -----------------------------------------------
template <typename Clause, typename Separator> struct ModifierList {
@@ -816,6 +833,9 @@ TYPE_PARSER(construct<OmpDependenceType>(
"SINK" >> pure(OmpDependenceType::Value::Sink) ||
"SOURCE" >> pure(OmpDependenceType::Value::Source)))
+TYPE_PARSER(construct<OmpDepinfoModifier>(
+ Parser<common::OmpDependenceKind>{}, parenthesized(Parser<OmpObject>{})))
+
TYPE_PARSER(construct<OmpDeviceModifier>(
"ANCESTOR" >> pure(OmpDeviceModifier::Value::Ancestor) ||
"DEVICE_NUM" >> pure(OmpDeviceModifier::Value::Device_Num)))
@@ -998,7 +1018,8 @@ TYPE_PARSER(sourced(
TYPE_PARSER(sourced(
// Try interop-type first, since prefer-type can take arbitrary strings.
construct<OmpInitClause::Modifier>(Parser<OmpInteropType>{}) ||
- construct<OmpInitClause::Modifier>(Parser<OmpPreferType>{})))
+ construct<OmpInitClause::Modifier>(Parser<OmpPreferType>{}) ||
+ construct<OmpInitClause::Modifier>(Parser<OmpDepinfoModifier>{})))
TYPE_PARSER(sourced(construct<OmpInReductionClause::Modifier>(
Parser<OmpReductionIdentifier>{})))
@@ -1105,11 +1126,7 @@ TYPE_PARSER(construct<OmpAffinityClause>(
// release
// seq_cst
TYPE_PARSER(construct<OmpAtomicDefaultMemOrderClause>(
- "ACQ_REL" >> pure(common::OmpMemoryOrderType::Acq_Rel) ||
- "ACQUIRE" >> pure(common::OmpMemoryOrderType::Acquire) ||
- "RELAXED" >> pure(common::OmpMemoryOrderType::Relaxed) ||
- "RELEASE" >> pure(common::OmpMemoryOrderType::Release) ||
- "SEQ_CST" >> pure(common::OmpMemoryOrderType::Seq_Cst)))
+ Parser<common::OmpMemoryOrderType>{}))
TYPE_PARSER(construct<OmpCancellationConstructTypeClause>(
OmpDirectiveNameParser{}, maybe(parenthesized(scalarLogicalExpr))))
@@ -1139,11 +1156,7 @@ TYPE_PARSER(construct<OmpEnterClause>(
Parser<OmpObjectList>{}))
TYPE_PARSER(construct<OmpFailClause>(
- "ACQ_REL" >> pure(common::OmpMemoryOrderType::Acq_Rel) ||
- "ACQUIRE" >> pure(common::OmpMemoryOrderType::Acquire) ||
- "RELAXED" >> pure(common::OmpMemoryOrderType::Relaxed) ||
- "RELEASE" >> pure(common::OmpMemoryOrderType::Release) ||
- "SEQ_CST" >> pure(common::OmpMemoryOrderType::Seq_Cst)))
+ Parser<common::OmpMemoryOrderType>{}))
TYPE_PARSER(construct<OmpGraphIdClause>(scalarIntExpr))
diff --git a/flang/lib/Parser/unparse.cpp b/flang/lib/Parser/unparse.cpp
index 19680dee7568d..7fe06b449ba95 100644
--- a/flang/lib/Parser/unparse.cpp
+++ b/flang/lib/Parser/unparse.cpp
@@ -2231,6 +2231,12 @@ class UnparseVisitor {
Walk(x.v);
Put(")");
}
+ void Unparse(const OmpDepinfoModifier &x) {
+ Walk(std::get<OmpDepinfoModifier::Value>(x.t));
+ Put("(");
+ Walk(std::get<OmpObject>(x.t));
+ Put(")");
+ }
void Unparse(const OmpStylizedDeclaration &x) {
// empty
}
diff --git a/flang/lib/Semantics/check-omp-structure.cpp b/flang/lib/Semantics/check-omp-structure.cpp
index edc6284544f5d..e5e07add0cdcc 100644
--- a/flang/lib/Semantics/check-omp-structure.cpp
+++ b/flang/lib/Semantics/check-omp-structure.cpp
@@ -1536,6 +1536,48 @@ void OmpStructureChecker::Leave(const parser::OmpDeclareVariantDirective &) {
dirContext_.pop_back();
}
+void OmpStructureChecker::CheckInitOnDepobj(
+ const parser::OpenMPDepobjConstruct &depobj,
+ const parser::OmpClause &initClause) {
+ const parser::OmpDirectiveSpecification &dirSpec{depobj.v};
+ const parser::OmpArgumentList &args{dirSpec.Arguments()};
+ const parser::OmpInitClause &init{
+ std::get<parser::OmpClause::Init>(initClause.u).v};
+
+ if (!args.v.empty()) {
+ context_.Say(args.source,
+ "The INIT clause is not allowed when the DEPOBJ directive has an argument"_err_en_US);
+ }
+
+ if (!OmpVerifyModifiers(
+ init, llvm::omp::Clause::OMPC_init, initClause.source, context_)) {
+ return;
+ }
+
+ auto &modifiers{OmpGetModifiers(init)};
+ if (auto *depInfo{
+ OmpGetUniqueModifier<parser::OmpDepinfoModifier>(modifiers)}) {
+ auto depKind{std::get<common::OmpDependenceKind>(depInfo->t)};
+ if (depKind == common::OmpDependenceKind::Depobj) {
+ auto &desc{OmpGetDescriptor<parser::OmpDepinfoModifier>()};
+ context_.Say(OmpGetModifierSource(modifiers, depInfo),
+ "'%s' is not am allowed value of the '%s' modifier"_err_en_US,
+ parser::ToUpperCaseLetters(EnumToString(depKind)), desc.name.str());
+ }
+ } else {
+ auto &desc{OmpGetDescriptor<parser::OmpDepinfoModifier>()};
+ context_.Say(initClause.source,
+ "The '%s' modifier is required on a DEPOBJ construct"_err_en_US,
+ desc.name.str());
+ }
+ if (auto *prefType{OmpGetUniqueModifier<parser::OmpPreferType>(modifiers)}) {
+ auto &desc{OmpGetDescriptor<parser::OmpPreferType>()};
+ context_.Say(OmpGetModifierSource(modifiers, prefType),
+ "The '%s' modifier is not allowed on a DEPOBJ construct"_err_en_US,
+ desc.name.str());
+ }
+}
+
void OmpStructureChecker::Enter(const parser::OpenMPDepobjConstruct &x) {
const auto &dirName{std::get<parser::OmpDirectiveName>(x.v.t)};
PushContextAndClauseSets(dirName.source, llvm::omp::Directive::OMPD_depobj);
@@ -1560,45 +1602,50 @@ void OmpStructureChecker::Enter(const parser::OpenMPDepobjConstruct &x) {
return;
}
- auto &clause{clauses.v.front()};
-
if (version >= 60 && arguments.v.empty()) {
context_.Say(x.source,
"DEPOBJ syntax with no argument is not handled yet"_err_en_US);
- return;
}
- // [5.2:73:27-28]
- // If the destroy clause appears on a depobj construct, destroy-var must
- // refer to the same depend object as the depobj argument of the construct.
- if (clause.Id() == llvm::omp::Clause::OMPC_destroy) {
- auto getObjSymbol{[&](const parser::OmpObject &obj) {
- return common::visit( //
- common::visitors{
- [&](auto &&s) { return GetLastName(s).symbol; },
- [&](const parser::OmpObject::Invalid &invalid) {
- return static_cast<Symbol *>(nullptr);
- },
- },
- obj.u);
- }};
- auto getArgSymbol{[&](const parser::OmpArgument &arg) {
- if (auto *locator{std::get_if<parser::OmpLocator>(&arg.u)}) {
- if (auto *object{std::get_if<parser::OmpObject>(&locator->u)}) {
- return getObjSymbol(*object);
- }
+ auto getObjSymbol{[&](const parser::OmpObject &obj) {
+ return common::visit( //
+ common::visitors{
+ [&](auto &&s) { return GetLastName(s).symbol; },
+ [&](const parser::OmpObject::Invalid &invalid) {
+ return static_cast<Symbol *>(nullptr);
+ },
+ },
+ obj.u);
+ }};
+ auto getArgSymbol{[&](const parser::OmpArgument &arg) {
+ if (auto *locator{std::get_if<parser::OmpLocator>(&arg.u)}) {
+ if (auto *object{std::get_if<parser::OmpObject>(&locator->u)}) {
+ return getObjSymbol(*object);
}
- return static_cast<Symbol *>(nullptr);
- }};
+ }
+ return static_cast<Symbol *>(nullptr);
+ }};
+
- auto &wrapper{std::get<parser::OmpClause::Destroy>(clause.u)};
- if (const std::optional<parser::OmpDestroyClause> &destroy{wrapper.v}) {
- const Symbol *constrSym{getArgSymbol(arguments.v.front())};
- const Symbol *clauseSym{getObjSymbol(destroy->v)};
- if (constrSym && clauseSym && constrSym != clauseSym) {
- context_.Say(x.source,
- "The DESTROY clause must refer to the same object as the "
- "DEPOBJ construct"_err_en_US);
+ for (auto &clause : clauses.v) {
+ llvm::omp::Clause clauseId{clause.Id()};
+
+ if (clauseId == llvm::omp::Clause::OMPC_init) {
+ CheckInitOnDepobj(x, clause);
+ } else if (clauseId == llvm::omp::Clause::OMPC_destroy) {
+ // [5.2:73:27-28]
+ // If the destroy clause appears on a depobj construct, destroy-var must
+ // refer to the same depend object as the depobj argument of the
+ // construct.
+ auto &wrapper{std::get<parser::OmpClause::Destroy>(clause.u)};
+ if (const std::optional<parser::OmpDestroyClause> &destroy{wrapper.v}) {
+ const Symbol *constrSym{getArgSymbol(arguments.v.front())};
+ const Symbol *clauseSym{getObjSymbol(destroy->v)};
+ if (constrSym && clauseSym && constrSym != clauseSym) {
+ context_.Say(x.source,
+ "The DESTROY clause must refer to the same object as the "
+ "DEPOBJ construct"_err_en_US);
+ }
}
}
}
@@ -5484,6 +5531,14 @@ void OmpStructureChecker::Enter(const parser::OpenMPInteropConstruct &x) {
++targetCount;
}
}
+ if (auto *depInfo{
+ OmpGetUniqueModifier<parser::OmpDepinfoModifier>(
+ modifiers)}) {
+ auto &desc{OmpGetDescriptor<parser::OmpDepinfoModifier>()};
+ context_.Say(OmpGetModifierSource(modifiers, depInfo),
+ "The '%s' is not allowed on INTEROP construct"_err_en_US,
+ desc.name.str());
+ }
}
const auto &interopVar{parser::Unwrap<parser::OmpObject>(
std::get<parser::OmpObject>(initClause.v.t))};
diff --git a/flang/lib/Semantics/check-omp-structure.h b/flang/lib/Semantics/check-omp-structure.h
index 4222259a56edb..9b5b0525dd27f 100644
--- a/flang/lib/Semantics/check-omp-structure.h
+++ b/flang/lib/Semantics/check-omp-structure.h
@@ -364,6 +364,8 @@ class OmpStructureChecker : public OmpStructureCheckerBase {
const parser::OmpObjectList &ompObjectList);
void CheckIfContiguous(const parser::OmpObject &object);
const parser::Name *GetObjectName(const parser::OmpObject &object);
+ void CheckInitOnDepobj(const parser::OpenMPDepobjConstruct &depobj,
+ const parser::OmpClause &initClause);
void CheckAllowedRequiresClause(llvmOmpClause clause);
bool deviceConstructFound_{false};
diff --git a/flang/lib/Semantics/openmp-modifiers.cpp b/flang/lib/Semantics/openmp-modifiers.cpp
index 12d857e4fc4ab..bf5a135c4ba00 100644
--- a/flang/lib/Semantics/openmp-modifiers.cpp
+++ b/flang/lib/Semantics/openmp-modifiers.cpp
@@ -288,6 +288,22 @@ const OmpModifierDescriptor &OmpGetDescriptor<parser::OmpDependenceType>() {
return desc;
}
+template <>
+const OmpModifierDescriptor &OmpGetDescriptor<parser::OmpDepinfoModifier>() {
+ static const OmpModifierDescriptor desc{
+ /*name=*/"depinfo-modifier",
+ /*props=*/
+ {
+ {60, {OmpProperty::Unique}},
+ },
+ /*clauses=*/
+ {
+ {60, {Clause::OMPC_init}},
+ },
+ };
+ return desc;
+}
+
template <>
const OmpModifierDescriptor &OmpGetDescriptor<parser::OmpDimsModifier>() {
static const OmpModifierDescriptor desc{
@@ -378,6 +394,7 @@ const OmpModifierDescriptor &OmpGetDescriptor<parser::OmpInteropType>() {
/*props=*/
{
{52, {OmpProperty::Required}},
+ {60, {}},
},
/*clauses=*/
{
diff --git a/flang/test/Parser/OpenMP/depobj-construct.f90 b/flang/test/Parser/OpenMP/depobj-construct.f90
index 1497414125aac..2d4831fe62bbb 100644
--- a/flang/test/Parser/OpenMP/depobj-construct.f90
+++ b/flang/test/Parser/OpenMP/depobj-construct.f90
@@ -1,5 +1,5 @@
-!RUN: %flang_fc1 -fdebug-unparse -fopenmp -fopenmp-version=52 %s | FileCheck --ignore-case --check-prefix="UNPARSE" %s
-!RUN: %flang_fc1 -fdebug-dump-parse-tree -fopenmp -fopenmp-version=52 %s | FileCheck --check-prefix="PARSE-TREE" %s
+!RUN: %flang_fc1 -fdebug-unparse-no-sema -fopenmp -fopenmp-version=60 %s | FileCheck --ignore-case --check-prefix="UNPARSE" %s
+!RUN: %flang_fc1 -fdebug-dump-parse-tree-no-sema -fopenmp -fopenmp-version=60 %s | FileCheck --check-prefix="PARSE-TREE" %s
subroutine f00
integer :: x, y
@@ -62,3 +62,22 @@ subroutine f03
!PARSE-TREE: | OmpDirectiveName -> llvm::omp::Directive = depobj
!PARSE-TREE: | OmpArgumentList -> OmpArgument -> OmpLocator -> OmpObject -> Designator -> DataRef -> Name = 'x'
!PARSE-TREE: | OmpClauseList -> OmpClause -> Destroy ->
+
+subroutine f04
+ integer :: x, y
+ !$omp depobj init(inoutset(x): y)
+end
+
+!UNPARSE: SUBROUTINE f04
+!UNPARSE: INTEGER x, y
+!UNPARSE: !$OMP DEPOBJ INIT(INOUTSET(x): y)
+!UNPARSE: END SUBROUTINE
+
+!PARSE-TREE: ExecutionPartConstruct -> ExecutableConstruct -> OpenMPConstruct -> OpenMPStandaloneConstruct -> OpenMPDepobjConstruct -> OmpDirectiveSpecification
+!PARSE-TREE: | OmpDirectiveName -> llvm::omp::Directive = depobj
+!PARSE-TREE: | OmpClauseList -> OmpClause -> Init -> OmpInitClause
+!PARSE-TREE: | | Modifier -> OmpDepinfoModifier
+!PARSE-TREE: | | | OmpDependenceKind = Inoutset
+!PARSE-TREE: | | | OmpObject -> Designator -> DataRef -> Name = 'x'
+!PARSE-TREE: | | OmpObject -> Designator -> DataRef -> Name = 'y'
+!PARSE-TREE: | Flags = {}
diff --git a/flang/test/Semantics/OpenMP/init-clause.f90 b/flang/test/Semantics/OpenMP/init-clause.f90
new file mode 100644
index 0000000000000..83b1a64ec2753
--- /dev/null
+++ b/flang/test/Semantics/OpenMP/init-clause.f90
@@ -0,0 +1,29 @@
+!RUN: %python %S/../test_errors.py %s %flang -fopenmp -fopenmp-version=60
+
+subroutine f00
+ integer :: x, y
+ !ERROR: The INIT clause is not allowed when the DEPOBJ directive has an argument
+ !ERROR: The 'depinfo-modifier' modifier is required on a DEPOBJ construct
+ !$omp depobj(x) init(y)
+end
+
+subroutine f01
+ integer :: x, y, z
+ !ERROR: DEPOBJ syntax with no argument is not handled yet
+ !ERROR: 'DEPOBJ' is not am allowed value of the 'depinfo-modifier' modifier
+ !$omp depobj init(depobj(y): z)
+end
+
+subroutine f02
+ integer :: x, y, z
+ !ERROR: DEPOBJ syntax with no argument is not handled yet
+ !ERROR: The 'depinfo-modifier' modifier is required on a DEPOBJ construct
+ !ERROR: The 'prefer-type' modifier is not allowed on a DEPOBJ construct
+ !$omp depobj init(prefer_type({fr("frid")}): z)
+end
+
+subroutine f03
+ integer :: x, y
+ !ERROR: The 'depinfo-modifier' is not allowed on INTEROP construct
+ !$omp interop init(mutexinoutset(x): y)
+end
diff --git a/llvm/include/llvm/Frontend/OpenMP/OMP.td b/llvm/include/llvm/Frontend/OpenMP/OMP.td
index 5cd8f7374866e..391cddaa54676 100644
--- a/llvm/include/llvm/Frontend/OpenMP/OMP.td
+++ b/llvm/include/llvm/Frontend/OpenMP/OMP.td
@@ -853,6 +853,7 @@ def OMP_Depobj : Directive<[Spelling<"depobj">]> {
// OMPKinds.def.
VersionedClause<OMPC_Depobj, 50>,
VersionedClause<OMPC_Destroy, 50>,
+ VersionedClause<OMPC_Init, 60>,
VersionedClause<OMPC_Update, 50>,
];
let association = AS_None;
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
tblah
reviewed
Dec 21, 2025
Co-authored-by: Kareem Ergawy <kareem.ergawy@amd.com>
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/27/builds/20818 Here is the relevant piece of the build log for the reference |
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Jan 6, 2026
…vm#173056) Co-authored-by: Kareem Ergawy <kareem.ergawy@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.