[NFC][asan] Try to deflake asan_lsan_deadlock test#137718
Merged
vitalybuka merged 2 commits intomainfrom Apr 28, 2025
Merged
Conversation
Created using spr 1.3.4
Member
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: Vitaly Buka (vitalybuka) Changes10s looks not enough. With highly parallel test I can reproduce locally 1s is not always enough, Additionally, don't use puts/CHECK to validate Full diff: https://github.com/llvm/llvm-project/pull/137718.diff 1 Files Affected:
diff --git a/compiler-rt/test/asan/TestCases/asan_lsan_deadlock.cpp b/compiler-rt/test/asan/TestCases/asan_lsan_deadlock.cpp
index 7ca07edbaf18c..7c2dbf27da3d4 100644
--- a/compiler-rt/test/asan/TestCases/asan_lsan_deadlock.cpp
+++ b/compiler-rt/test/asan/TestCases/asan_lsan_deadlock.cpp
@@ -36,11 +36,8 @@
void Watchdog() {
// Safety mechanism: Turn infinite deadlock into finite test failure
- usleep(10000000);
- // CHECK-NOT: Timeout! Deadlock detected.
- puts("Timeout! Deadlock detected.");
- fflush(stdout);
- _exit(1);
+ sleep(60);
+ _exit(0);
}
int main(int argc, char **argv) {
|
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
10s looks not enough. With highly parallel test execution on VMs it's very possible that Asan report will have no enough time to produce output. I can reproduce locally 1s is not always enough, but likely my workstation is faster then buildbot. Additionally, don't use puts/CHECK to validate timeout. We can exit with 0 and it should violate "not" expectation. Follow up to llvm#131756.
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
10s looks not enough. With highly parallel test execution on VMs it's very possible that Asan report will have no enough time to produce output. I can reproduce locally 1s is not always enough, but likely my workstation is faster then buildbot. Additionally, don't use puts/CHECK to validate timeout. We can exit with 0 and it should violate "not" expectation. Follow up to llvm#131756.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
10s looks not enough. With highly parallel test
execution on VMs it's very possible that Asan
report will have no enough time to produce output.
I can reproduce locally 1s is not always enough,
but likely my workstation is faster then buildbot.
Additionally, don't use puts/CHECK to validate
timeout. We can exit with 0 and it should violate
"not" expectation.
Follow up to #131756.