Merged
Conversation
Created using spr 1.3.6-beta.1
Member
|
@llvm/pr-subscribers-backend-msp430 @llvm/pr-subscribers-clang Author: Alexander Richardson (arichardson) ChangesThis matches the ABI document at https://www.ti.com/lit/pdf/slaa534 as Partially fixes #115957. Full diff: https://github.com/llvm/llvm-project/pull/115964.diff 2 Files Affected:
diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp
index 0952262c360185..75379e0a00b981 100644
--- a/clang/lib/Driver/ToolChains/Clang.cpp
+++ b/clang/lib/Driver/ToolChains/Clang.cpp
@@ -1341,6 +1341,7 @@ static bool isSignedCharDefault(const llvm::Triple &Triple) {
return false;
case llvm::Triple::hexagon:
+ case llvm::Triple::msp430:
case llvm::Triple::ppcle:
case llvm::Triple::ppc64le:
case llvm::Triple::riscv32:
diff --git a/clang/test/Driver/msp430-char.c b/clang/test/Driver/msp430-char.c
new file mode 100644
index 00000000000000..4f62eb167e1c84
--- /dev/null
+++ b/clang/test/Driver/msp430-char.c
@@ -0,0 +1,5 @@
+/// Check that char is unsigned by default.
+// RUN: %clang -### %s --target=msp430 -c 2>&1
+// RUN: %clang -### %s --target=msp430 -c 2>&1 | FileCheck%s
+// CHECK: "-cc1" "-triple" "msp430"
+// CHECK-SAME: "-fno-signed-char"
|
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
This was referenced Nov 13, 2024
espressif-bot
pushed a commit
to espressif/llvm-project
that referenced
this pull request
Dec 24, 2024
This matches GCC. Partially addresses llvm#115964 Pull Request: llvm#115967
espressif-bot
pushed a commit
to espressif/llvm-project
that referenced
this pull request
Jan 17, 2025
This matches GCC. Partially addresses llvm#115964 Pull Request: llvm#115967
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 28, 2025
Update comments and sort target_arch in c_char_definition Follow-up to rust-lang#132975. - Clang's wrong default on MSP430 has been fixed in llvm/llvm-project#115964, and will be included in LLVM 20, which will be used soon. - Add a reference on Xtensa's default (from rust-lang#132975 (comment)). - Fix link for Windows's default. - Add a link to the discussion on L4Re (rust-lang#132975 (comment)) - Sort `target_arch`. (now match with `target_arch`s in comments) r? `@tgross35`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 28, 2025
Rollup merge of rust-lang#136173 - taiki-e:c-char, r=tgross35 Update comments and sort target_arch in c_char_definition Follow-up to rust-lang#132975. - Clang's wrong default on MSP430 has been fixed in llvm/llvm-project#115964, and will be included in LLVM 20, which will be used soon. - Add a reference on Xtensa's default (from rust-lang#132975 (comment)). - Fix link for Windows's default. - Add a link to the discussion on L4Re (rust-lang#132975 (comment)) - Sort `target_arch`. (now match with `target_arch`s in comments) r? `@tgross35`
github-actions bot
pushed a commit
to tautschnig/verify-rust-std
that referenced
this pull request
Mar 11, 2025
Update comments and sort target_arch in c_char_definition Follow-up to rust-lang#132975. - Clang's wrong default on MSP430 has been fixed in llvm/llvm-project#115964, and will be included in LLVM 20, which will be used soon. - Add a reference on Xtensa's default (from rust-lang#132975 (comment)). - Fix link for Windows's default. - Add a link to the discussion on L4Re (rust-lang#132975 (comment)) - Sort `target_arch`. (now match with `target_arch`s in comments) r? `@tgross35`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the ABI document at https://www.ti.com/lit/pdf/slaa534 as
well as the GCC implementation.
Partially fixes #115957.