Revert "[libc++][modules] Rewrite the modulemap to have fewer top-level modules (#107638)"#110384
Conversation
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-libcxx Author: Chris B (llvm-beanz) ChangesThis reverts commit bc6bd3b. The GitHub pre-merge CI has been broken since this PR went in. This change reverts it to see if I can get the pre-merge CI working again. Patch is 214.27 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/110384.diff 8 Files Affected:
|
You can test this locally with the following command:View the diff from darker here. |
You can test this locally with the following command:View the diff from clang-format here. |
45a6af7 to
f70512c
Compare
…or[] (llvm#91798)" This reverts commit 45a09d1.
This reverts commit 24bc324.
…el modules (llvm#107638)" This reverts commit bc6bd3b.
f70512c to
1cc92ee
Compare
boomanaiden154
left a comment
There was a problem hiding this comment.
LGTM, assuming precommit CI passes.
|
@llvm-beanz The changes to clang/include/clang/AST/Expr.h seem to be unrelated, no? |
615caf2 to
1cc92ee
Compare
|
All checks passed. I'm reverting the top commit that was just to force the clang tests to run and merging the revert of the remaining 3 changes. I confirmed with @ldionne that he is going to look at the issues on Monday. |
I reverted the commit modifying Clang before landing the PR, it was required to get the pre-merge CI to run the failing Clang CI to verify that my revert resolved the issue. There was an extensive discussion of this on the #infrastructure channel on Discord with @boomanaiden154. |
This reverts 3 commits:
45a09d1
24bc324
bc6bd3b
The GitHub pre-merge CI has been broken since this PR went in. This change reverts it to see if I can get the pre-merge CI working again.