[lldb] Fix test expectation in TestFrameRecognizer.py#106281
Merged
vogelsgesang merged 1 commit intollvm:mainfrom Aug 27, 2024
Merged
[lldb] Fix test expectation in TestFrameRecognizer.py#106281vogelsgesang merged 1 commit intollvm:mainfrom
TestFrameRecognizer.py#106281vogelsgesang merged 1 commit intollvm:mainfrom
Conversation
Member
|
@llvm/pr-subscribers-lldb Author: Adrian Vogelsgesang (vogelsgesang) ChangesFull diff: https://github.com/llvm/llvm-project/pull/106281.diff 1 Files Affected:
diff --git a/lldb/test/API/commands/frame/recognizer/TestFrameRecognizer.py b/lldb/test/API/commands/frame/recognizer/TestFrameRecognizer.py
index e25df2b6cdc245..0621fdbc669193 100644
--- a/lldb/test/API/commands/frame/recognizer/TestFrameRecognizer.py
+++ b/lldb/test/API/commands/frame/recognizer/TestFrameRecognizer.py
@@ -58,7 +58,7 @@ def test_frame_recognizer_1(self):
self.expect(
"frame recognizer list",
substrs=[
- "1: recognizer.MyOtherFrameRecognizer, module a.out, demangled symbol bar (regexp)"
+ "1: recognizer.MyOtherFrameRecognizer, module a.out, demangled symbol regex bar"
],
)
self.expect(
|
2fdc99f to
b32e85a
Compare
Member
Author
|
@adrian-prantl It seems I overlooked this test expectation. This hopefully fixes the build issue in https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/10463/ . Unfortunately, i was not able to run this test locally, it is marked as "unsupported" for some reason |
Michael137
approved these changes
Aug 27, 2024
felipepiovezan
pushed a commit
to felipepiovezan/llvm-project
that referenced
this pull request
Oct 30, 2024
(cherry picked from commit fc51797)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.