Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

[Bug 19350] remember iconPresetName when reopening#5232

Merged
livecodepanos merged 4 commits intolivecode:develop-8.1from
BerndN:patch-1
Mar 2, 2017
Merged

[Bug 19350] remember iconPresetName when reopening#5232
livecodepanos merged 4 commits intolivecode:develop-8.1from
BerndN:patch-1

Conversation

@BerndN
Copy link
Copy Markdown
Contributor

@BerndN BerndN commented Mar 2, 2017

makes svgpath remember the iconPresetName when reopening stack
http://quality.livecode.com/show_bug.cgi?id=19350

@livecodepanos
Copy link
Copy Markdown
Contributor

livecodepanos commented Mar 2, 2017

Thank you @BerndN. Looks good to me. Some minor changes in the bugfix note:

  1. The bugfix notes for widgets seem to have slightly different naming rules:

So
extensions/widgets/svgpath/notes/bugfix-19350.md should be renamed to extensions/widgets/svgpath/notes/19350.md

  1. Make sure it starts with #, otherwise our release-note builder will be unhappy.
  2. I think # has to be followed by [19350] in this case.

So the content of extensions/widgets/svgpath/notes/19350.md should be:

# [19350] Remember iconPresetName in SVG Icon when reopening

(This is based in this example bugfix note for widgets: https://raw.githubusercontent.com/livecode/livecode/develop/extensions/widgets/header/notes/17790.md)

livecodeali
livecodeali reviewed Mar 2, 2017
View reviewed changes
extensions/widgets/svgpath/svgpath.lcb Outdated
put pProperties["flip vertically"] into mFlipVertically
put pProperties["angle"] into mAngle

put pProperties["iconPresetName"] into mPathName
Copy link
Copy Markdown
Member

@livecodeali livecodeali Mar 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should put this in a if "iconPresetName" is among the keys of pProperties block so that existing saved instances of SVG widget do not error when they load.

@BerndN
Copy link
Copy Markdown
Contributor Author

BerndN commented Mar 2, 2017

@livecodeali thanks, now I understand better the recomendation to always use an if-then clause in onOpen.
@livecodepanos thanks, hopefully formatted correctly now

@livecodepanos
Copy link
Copy Markdown
Contributor

livecodepanos commented Mar 2, 2017

Thank you @BerndN.

@livecodeali could you review please?

@livecodeali
Copy link
Copy Markdown
Member

livecodeali commented Mar 2, 2017

@livecode-vulcan review ok df50706

@livecode-vulcan
Copy link
Copy Markdown
Contributor

livecode-vulcan commented Mar 2, 2017

💙 review by @livecodeali ok df50706

livecode-vulcan added a commit that referenced this pull request Mar 2, 2017
@livecode-vulcan
Auto-merge pull request #5232 from BerndN/patch-1
e1af488 
[Bug 19350] remember iconPresetName when reopening

makes svgpath remember the iconPresetName when reopening stack
http://quality.livecode.com/show_bug.cgi?id=19350
@livecode-vulcan
Copy link
Copy Markdown
Contributor

livecode-vulcan commented Mar 2, 2017

😎 test success df50706

@livecodepanos livecodepanos added this to the 8.1.4-rc-1 milestone Mar 2, 2017
@livecodepanos livecodepanos merged commit 3f74d74 into livecode:develop-8.1 Mar 2, 2017
@BerndN BerndN deleted the patch-1 branch March 2, 2017 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@livecodeali livecodeali livecodeali left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug vulcan/reviewed

Projects

None yet

Milestone

8.1.4-rc-1

Development

Successfully merging this pull request may close these issues.

4 participants

@BerndN @livecodepanos @livecodeali @livecode-vulcan