This repository was archived by the owner on Aug 31, 2021. It is now read-only.
Use a temporary reg in repeat for each syntax#4596
Merged
peter-b merged 2 commits intolivecode:developfrom Oct 4, 2016
Merged
Conversation
The length of the handler is giving the compiler some problems so this works around the issue for now. A more fundamental fix is needed though.
This avoids problems with stale or unpredicable data being in the register and being passed to iterators as the wrong type.
Contributor
Author
|
@livecode-vulcan reviewed by @peter-b okay 2893b80 |
Contributor
livecode-vulcan
added a commit
that referenced
this pull request
Sep 30, 2016
Use a temporary reg in `repeat for each` syntax This avoids type errors when passing data into and out of the iteration methods. As a side effect, one of the key methods inside the compiler became more complex, pushing it over the edge in terms of memory use when compiling the iconsvg library. The library has been re-arranged slightly to stave off the problem for a little while. (A proper fix is needed but is outside the scope of this change).
Contributor
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids type errors when passing data into and out of the iteration methods.
As a side effect, one of the key methods inside the compiler became more complex, pushing it over the edge in terms of memory use when compiling the iconsvg library. The library has been re-arranged slightly to stave off the problem for a little while. (A proper fix is needed but is outside the scope of this change).