[Java FFI][Bug 18846] Implement a parser for the Java FFI DSL by livecodeali · Pull Request #4548 · livecode/livecode

livecodeali · 2016-09-22T16:19:47Z

Replaces #4438

This parser is written in gentle and is largely based on lc-compile. The main difference is the fact that names are qualified, and accordingly '.' is not allowed in name literals.

Add a --check option to the java-dsl-parse program which combines the input files into one and outputs to the specified file. This is used to check the idempotence of the parsing step.

Add a java dsl parser test runner (base on the lc-compile one) and add tests.

Add an --output option to the java-dsl-parse program which outputs LCB glue code to the specified location. The glue code enables the methods, constructors, variables and constants of the java class described in the target DSL files to be accessed from LCB.

Call the to-be-implemented java.lcb module code when generating constructor glue.

We don't yet support variadic args in LCB, so use a list for the time being. Calling such functions through the JNI will not work until the relevant support is added to the java.lcb libscript module.

Fix an issue whereby parameters qualified names could not be retrieved.

Add a check to ensure generic type parameters match properly.

…arser [Java FFI][Bug 18846] Implement a parser for the Java FFI DSL Replaces #4438

livecode-vulcan · 2017-02-23T16:34:14Z

😞 test failure 4468582

try-community-linux-x86: success
try-community-mac: success
try-community-linux-x86_64: success
try-community-emscripten: success
try-community-ios: success
try-community-win-x86: failure
try-community-android-armv6: success

We need to be able to use the general type bridging system to call constructors with parameters easily, so this patch adds glue code for constructors which adds a foreign binding string of the form "java:qualified.class.name>new(paramString)" Correspondingly, glue code is generated to call constructors with the appropriate types and return the constructed java object.

This patch adds a special case to generate glue code for converting java byte arrays to Data and back. This means that it is not necessary to hard-code the conversion in libfoundation, so that in future better glue code could be generated to elide conversion when java byteArrays are passed around.

- Ensure static methods and fields are marked as such in the binding string using !static - Generate getters for variables and constants, and setters for non-final variables

peter-b · 2016-10-21T14:22:07Z

toolchain/java-dsl-parse/src/LAYOUT.b

@@ -0,0 +1,2 @@
+\  { AdvanceCurrentPosition(1); }
+\t {  }


You need to AdvanceCurrentPosition(1); for tab characters, or column numbers will be reported incorrectly when errors occur on lines indented with tabs.

peter-b · 2016-10-21T14:22:15Z

toolchain/java-dsl-parse/src/DOUBLE_LITERAL.t

@@ -0,0 +1,6 @@
+[0-9]+"."[0-9]+([eE][-+]?[0-9]+)? {


It looks like 1e1 is not parsed as a numeric literal, although it is a numeric literal in LCB. This isn't necessarily a problem, but it's probably something to be aware of.

peter-b

Oops, I found one minor issue that I didn't flag up properly earlier.

peter-b · 2017-02-27T11:43:41Z

toolchain/lc-compile-ffi-java/src/LAYOUT.b

@@ -0,0 +1,2 @@
+\  { AdvanceCurrentPosition(1); }
+\t {  }


You need to AdvanceCurrentPosition for tab characters, or the incorrect column number will be reported in error and warning messages.

Good catch :-)

peter-b · 2017-02-27T11:56:15Z

@livecode-vulcan review ok 5e452a7

livecode-vulcan · 2017-02-27T11:56:55Z

💙 review by @peter-b ok 5e452a7

…arser [Java FFI][Bug 18846] Implement a parser for the Java FFI DSL Replaces #4438

livecode-vulcan · 2017-02-27T12:15:59Z

😞 test failure 5e452a7

try-community-linux-x86: success
try-community-mac: success
try-community-linux-x86_64: success
try-community-emscripten: success
try-community-ios: success
try-community-win-x86: failure
try-community-android-armv6: success

peter-b · 2017-02-27T12:26:59Z

@livecode-vulcan review ok 33f63c2

livecode-vulcan · 2017-02-27T12:28:47Z

💙 review by @peter-b ok 33f63c2

…arser [Java FFI][Bug 18846] Implement a parser for the Java FFI DSL Replaces #4438

livecode-vulcan · 2017-02-27T12:49:12Z

😎 test success 33f63c2

try-community-linux-x86: success
try-community-mac: success
try-community-linux-x86_64: success
try-community-emscripten: success
try-community-ios: success
try-community-win-x86: success
try-community-android-armv6: success

livecodeali added enhancement WIP need-docs need-release-notes labels Sep 22, 2016

livecodeali added this to the 9.0.0-dp-1 milestone Sep 22, 2016

livecodeali force-pushed the feature-java_ffi_dsl_parser branch 2 times, most recently from ad29e99 to 8750569 Compare September 30, 2016 11:11

peter-b modified the milestones: 9.0.0-dp-1, 9.0.0-dp-2 Sep 30, 2016

livecodeali force-pushed the feature-java_ffi_dsl_parser branch from 51649ba to a58622c Compare October 6, 2016 14:34

livecodeali removed need-docs need-release-notes WIP labels Oct 6, 2016

livecodeali changed the title ~~Feature java ffi dsl parser~~ [[ Java FFI DSL ]] Implement a parser for the Java FFI DSL Oct 6, 2016

livecodeali added 9 commits October 6, 2016 15:41

[[ Java FFI ]] Add Java FFI DSL parser

4671268

This parser is written in gentle and is largely based on lc-compile. The main difference is the fact that names are qualified, and accordingly '.' is not allowed in name literals.

[[ Java FFI ]] Add Java FFI DSL check output

a754e0e

Add a --check option to the java-dsl-parse program which combines the input files into one and outputs to the specified file. This is used to check the idempotence of the parsing step.

[[ Java FFI ]] Add parser checking and tests

809c1bf

Add a java dsl parser test runner (base on the lc-compile one) and add tests.

[[ Java FFI DSL ]] Generate constructor code properly

c0dc74b

Call the to-be-implemented java.lcb module code when generating constructor glue.

[[ Java FFI DSL ]] Add placeholders to deal with variadic args

1093042

We don't yet support variadic args in LCB, so use a list for the time being. Calling such functions through the JNI will not work until the relevant support is added to the java.lcb libscript module.

[[ Java FFI DSL ]] Ensure params are applied correctly

c50f4de

Fix an issue whereby parameters qualified names could not be retrieved.

[[ Java FFI DSL ]] Check template types parameters match

1d9a435

Add a check to ensure generic type parameters match properly.

[[ Java FFI DSL ]] Allow unbounded wildcards in named type parameters

87b6aaf

livecodeali force-pushed the feature-java_ffi_dsl_parser branch from a58622c to e7e5ad1 Compare October 6, 2016 14:52

[[ Java FFI DSL ]] Add docs for java dsl parser

a2b5f3f

livecodeali force-pushed the feature-java_ffi_dsl_parser branch from e7e5ad1 to a2b5f3f Compare October 9, 2016 20:22

peter-b changed the title ~~[[ Java FFI DSL ]] Implement a parser for the Java FFI DSL~~ [Java FFI][Bug 18846] Implement a parser for the Java FFI DSL Nov 14, 2016

peter-b removed this from the 9.0.0-dp-2 milestone Nov 21, 2016

livecode-vulcan added a commit that referenced this pull request Feb 23, 2017

Auto-merge pull request #4548 from livecodeali/feature-java_ffi_dsl_p…

ac930fb

…arser [Java FFI][Bug 18846] Implement a parser for the Java FFI DSL Replaces #4438

[[ LC Compile FFI Java ]] Declare vars at beginning of handler

b3b6903

livecode-vulcan removed the vulcan/reviewed label Feb 24, 2017

livecodeali force-pushed the feature-java_ffi_dsl_parser branch from d0cb8ae to 50cf68e Compare February 24, 2017 15:54

peter-b modified the milestones: 9.0.0-dp-5, 9.0.0-dp-6 Feb 24, 2017

livecodeali added 2 commits February 24, 2017 18:07

livecodeali force-pushed the feature-java_ffi_dsl_parser branch from 50cf68e to cd5c9b0 Compare February 24, 2017 18:08

[[ LC Compile FFI Java ]] Ensure generated glue code is correct

b6cc60e

- Ensure static methods and fields are marked as such in the binding string using !static - Generate getters for variables and constants, and setters for non-final variables

livecodeali force-pushed the feature-java_ffi_dsl_parser branch from cbdec86 to b6cc60e Compare February 27, 2017 08:13

peter-b approved these changes Feb 27, 2017

View reviewed changes

peter-b suggested changes Feb 27, 2017

View reviewed changes

[[ LC Compile FFI Java ]] Advance position for tab character

5e452a7

peter-b approved these changes Feb 27, 2017

View reviewed changes

livecode-vulcan added the vulcan/reviewed label Feb 27, 2017

livecode-vulcan added a commit that referenced this pull request Feb 27, 2017

Auto-merge pull request #4548 from livecodeali/feature-java_ffi_dsl_p…

4ac61ed

…arser [Java FFI][Bug 18846] Implement a parser for the Java FFI DSL Replaces #4438

[[ LC Cpmpile FFI Java ]] Always define yywrap

33f63c2

livecode-vulcan added a commit that referenced this pull request Feb 27, 2017

Auto-merge pull request #4548 from livecodeali/feature-java_ffi_dsl_p…

16bfa78

…arser [Java FFI][Bug 18846] Implement a parser for the Java FFI DSL Replaces #4438

livecodeali merged commit 9b9146b into livecode:develop Feb 27, 2017

livecodeali deleted the feature-java_ffi_dsl_parser branch February 27, 2017 12:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Java FFI][Bug 18846] Implement a parser for the Java FFI DSL#4548

[Java FFI][Bug 18846] Implement a parser for the Java FFI DSL#4548
livecodeali merged 27 commits intolivecode:developfrom
livecodeali:feature-java_ffi_dsl_parser

livecodeali commented Sep 22, 2016

Uh oh!

livecode-vulcan commented Feb 23, 2017

Uh oh!

peter-b Oct 21, 2016

Uh oh!

peter-b Oct 21, 2016

Uh oh!

peter-b left a comment

Uh oh!

peter-b Feb 27, 2017

Uh oh!

livecodeali Feb 27, 2017

Uh oh!

peter-b commented Feb 27, 2017

Uh oh!

livecode-vulcan commented Feb 27, 2017

Uh oh!

livecode-vulcan commented Feb 27, 2017

Uh oh!

peter-b commented Feb 27, 2017

Uh oh!

livecode-vulcan commented Feb 27, 2017

Uh oh!

livecode-vulcan commented Feb 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

		@@ -0,0 +1,2 @@
		\ { AdvanceCurrentPosition(1); }
		\t { } No newline at end of file

Conversation

livecodeali commented Sep 22, 2016

Uh oh!

livecode-vulcan commented Feb 23, 2017

Uh oh!

peter-b Oct 21, 2016

Choose a reason for hiding this comment

Uh oh!

peter-b Oct 21, 2016

Choose a reason for hiding this comment

Uh oh!

peter-b left a comment

Choose a reason for hiding this comment

Uh oh!

peter-b Feb 27, 2017

Choose a reason for hiding this comment

Uh oh!

livecodeali Feb 27, 2017

Choose a reason for hiding this comment

Uh oh!

peter-b commented Feb 27, 2017

Uh oh!

livecode-vulcan commented Feb 27, 2017

Uh oh!

livecode-vulcan commented Feb 27, 2017

Uh oh!

peter-b commented Feb 27, 2017

Uh oh!

livecode-vulcan commented Feb 27, 2017

Uh oh!

livecode-vulcan commented Feb 27, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants