This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ PostgreSQL SSL ]] Updated dbpostgresql to support secure connections.#3067
Merged
livecodemichael merged 6 commits intolivecode:developfrom Oct 20, 2015
Merged
Conversation
…secure connections. The dbpostgresql database driver was updated to weakly link against libcrypto and libssl. The revOpenDatabase function was updated for postgres to take 6 extra parameters that determine the nature of the SSL connection. dbpostgresql was updated to connect using PQconnectdbParams, passing through the extra SSL paramters.
…tion options as key value pairs. It was decided that key=value parameters were easier to use than one specific parameter per SSL option. Now any number of additional paramters can be passed to revOpenDatabase (for PostgreSQL connections) each specifying an SSL option in the form option_name=option_value. The docs note and dictionary entry have been updated accordingly.
Contributor
|
@livecodemichael: The 64-bit Linux build failed on Travis. Could you please investigate? Thanks. 👍 |
Contributor
|
@livecodemichael: I think the third-party submodule pointer hasn't been updated |
revdb/src/postgresql_connection.cpp
Outdated
Contributor
There was a problem hiding this comment.
You shouldn't really do this - the string is a const char * - it probably shouldn't be mutated ;)
…ssed to revdb connect.
Contributor
|
@livecode-vulcan review ok d05fb6e |
Contributor
|
💙 review by @runrevmark ok d05fb6e |
livecode-vulcan
added a commit
that referenced
this pull request
Oct 19, 2015
…_ssl [[ PostgreSQL SSL ]] Updated dbpostgresql to support secure connections. This pull request relies on livecode/livecode-thirdparty#31
Contributor
livecodemichael
added a commit
that referenced
this pull request
Oct 20, 2015
[[ PostgreSQL SSL ]] Updated dbpostgresql to support secure connections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request relies on livecode/livecode-thirdparty#31