This repository was archived by the owner on Aug 31, 2021. It is now read-only.
Fixes for some of the minor issues blocking 64-bit Mac support#3036
Merged
livecodefraser merged 9 commits intolivecode:developfrom Oct 12, 2015
Merged
Fixes for some of the minor issues blocking 64-bit Mac support#3036livecodefraser merged 9 commits intolivecode:developfrom
livecodefraser merged 9 commits intolivecode:developfrom
Conversation
For 64-bit OSX, the type CGFloat is a typedef for double, not float. So make sure we pass an array of CGFloat and not float to a method expecting CGFloat.
CGFloat is a double (== float64_t) and not a float, so if we want to use min/max on it, we need this overload.
There isn't a direct replacement, so an undocumented preferences key needs to be queried instead (NSTextInsertionPointBlinkPeriod). This key is widely discussed on the internet so seems to be fairly reliable. Just in case it isn't, a fallback value is provided that uses the default blink rate for my OSX system.
Contributor
|
Reviewed 1 of 1 files at r1, 4 of 4 files at r2, 1 of 1 files at r4, 1 of 1 files at r5, 1 of 1 files at r6, 1 of 1 files at r7, 1 of 1 files at r8. engine/src/osxprefix.h, line 26 [r3] (raw file): Comments from the review on Reviewable.io |
Contributor
|
Per off-line conversation with @livecodefraser, @livecode-vulcan review ok 4224c5e |
Contributor
livecode-vulcan
added a commit
that referenced
this pull request
Oct 12, 2015
Fixes for some of the minor issues blocking 64-bit Mac support Each of the commits in this PR addresses a different issue so are best reviewed individually. The general theme of this PR is changing some Carbon-specific APIs to their Cocoa replacements. There are a number of large chunks of code that aren't 64-bit compatible yet; this PR just cleans up some of the low-hanging fruit.
Contributor
livecodefraser
added a commit
that referenced
this pull request
Oct 12, 2015
Fixes for some of the minor issues blocking 64-bit Mac support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each of the commits in this PR addresses a different issue so are best reviewed individually. The general theme of this PR is changing some Carbon-specific APIs to their Cocoa replacements.
There are a number of large chunks of code that aren't 64-bit compatible yet; this PR just cleans up some of the low-hanging fruit.