Skip to content

fix: Enable provide with stateful callable and cleanup#4459

Merged
provinzkraut merged 4 commits intolitestar-org:mainfrom
enrico-stauss:fix/provide-with-callable-generator
Jan 7, 2026
Merged

fix: Enable provide with stateful callable and cleanup#4459
provinzkraut merged 4 commits intolitestar-org:mainfrom
enrico-stauss:fix/provide-with-callable-generator

Conversation

@enrico-stauss
Copy link
Copy Markdown
Contributor

Description

Fix the Provide class for callable class instances returning an (Async) Generator.

Closes #4457

@enrico-stauss enrico-stauss requested review from a team as code owners November 5, 2025 09:04
@enrico-stauss enrico-stauss changed the title Fix/provide with callable generator fix: Enable provide with stateful callable and cleanup Nov 5, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.83%. Comparing base (7dc6b46) to head (27a637f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4459   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files         296      296           
  Lines       15303    15308    +5     
  Branches     1715     1716    +1     
=======================================
+ Hits        14972    14977    +5     
  Misses        189      189           
  Partials      142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@enrico-stauss
Copy link
Copy Markdown
Contributor Author

Hi @provinzkraut , thanks for your review, that was an obvious oversight on my end. I commited as per your suggestion and the PR should be ready to merge :)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 2, 2025

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4459

@enrico-stauss
Copy link
Copy Markdown
Contributor Author

Hey @provinzkraut , any chance we can move on with this PR? :)

@provinzkraut provinzkraut force-pushed the fix/provide-with-callable-generator branch from d0961d0 to 27a637f Compare January 7, 2026 10:42
@provinzkraut provinzkraut enabled auto-merge (squash) January 7, 2026 10:42
@provinzkraut provinzkraut merged commit ce25bff into litestar-org:main Jan 7, 2026
25 checks passed
provinzkraut pushed a commit that referenced this pull request Jan 25, 2026
* test: Add test cases for (stateful) generator dependencies

* fix: Ensure callable generator class instances are marked correctly

* chore: Resolve mypy and pyright failures

* chore: Remove superfluous duplicate check

Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>

---------

Co-authored-by: Enrico Stauss <enrico.stauss@pace.de>
Co-authored-by: Janek Nouvertné <provinzkraut@posteo.de>

(cherry picked from commit ce25bff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Provide fails to detect generator methods on callable instances

2 participants