refactor: type annotate content properly#4427
Merged
provinzkraut merged 2 commits intolitestar-org:mainfrom Oct 12, 2025
Merged
refactor: type annotate content properly#4427provinzkraut merged 2 commits intolitestar-org:mainfrom
content properly#4427provinzkraut merged 2 commits intolitestar-org:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4427 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 296 296
Lines 15286 15286
Branches 1711 1711
=======================================
Hits 14955 14955
Misses 189 189
Partials 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
euri10
reviewed
Oct 12, 2025
4f78e31 to
e074ad7
Compare
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4427 |
provinzkraut
approved these changes
Oct 12, 2025
provinzkraut
pushed a commit
that referenced
this pull request
Dec 13, 2025
* refactor: type annotate `content` properly * refactor: reuse `DEFAULT_SEPARATOR` (cherry picked from commit 08e8dad)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a series of small changes to reduce noise for an eventual generator propagation fix.
Changes
contentto be aCallable, we should type it as such.AnyasServerSentEventMessageis typedstr | int | bytes | None.DEFAULT_HEADERin SSE header builder