fix: KeyError swallowing in default_serializer#4420
Merged
provinzkraut merged 2 commits intomainfrom Oct 11, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4420 +/- ##
=======================================
Coverage 97.83% 97.83%
=======================================
Files 296 296
Lines 15288 15288
Branches 1711 1711
=======================================
Hits 14957 14957
Misses 189 189
Partials 142 142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Really? Do you know why? I was under the impression that since 3.11 (I think it was this version?), |
Member
Author
|
Yeap, you are right :)
vs I will update my PR. |
provinzkraut
approved these changes
Oct 11, 2025
KeyError swallowing in default_serializerKeyError swallowing in default_serializer
It used to do several things that are not quite right: 1. `KeyError` raised in `encoder(value)` call was swallowed, it could potentially lead to a very hard to debug problems, when a `KeyError` bug in encoder would just select another one 2. `.get` is a bit tiny faster than `[]` with `except KeyError` in some cases
c704f9c to
3a8ea88
Compare
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4420 |
provinzkraut
pushed a commit
that referenced
this pull request
Dec 13, 2025
(cherry picked from commit 673c1e9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It used to do several things that are not quite right:
KeyErrorraised inencoder(value)call was swallowed, it could potentially lead to a very hard to debug problems, when aKeyErrorbug in encoder would just select another one.get+if is Noneis a bit tiny faster than[]withexcept KeyErrorin some cases