fix(channels/plugin): fix typo with pub_task cancelling in _on_shutdown method ChannelsPlugin#4374
Merged
provinzkraut merged 14 commits intolitestar-org:mainfrom Oct 2, 2025
Merged
Conversation
_on_shutdown method ChannelsPlugin
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4374 +/- ##
=======================================
Coverage 97.93% 97.93%
=======================================
Files 319 319
Lines 15569 15569
Branches 1721 1721
=======================================
Hits 15247 15247
Misses 184 184
Partials 138 138 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
euri10
approved these changes
Oct 1, 2025
Contributor
euri10
left a comment
There was a problem hiding this comment.
good catch, looks logical
i'm curious how did you find that inconsistency ?
Contributor
Author
@euri10 I wanted to see how ChannelsPlugin is implemented under the hood and accidentally stumbled upon this |
sobolevn
reviewed
Oct 1, 2025
provinzkraut
reviewed
Oct 2, 2025
provinzkraut
requested changes
Oct 2, 2025
provinzkraut
reviewed
Oct 2, 2025
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4374 |
provinzkraut
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the variable assignment bug in
_on_shutdownChannelsPluginCloses #4373