fix(cli): pass the --app-dir option to the uvicorn subprocess when the reload option is enabled.#4352
Merged
provinzkraut merged 1 commit intolitestar-org:mainfrom Oct 3, 2025
Conversation
dcb4604 to
5b27f9a
Compare
euri10
reviewed
Oct 3, 2025
Contributor
euri10
left a comment
There was a problem hiding this comment.
seems reasonable to me, @litestar-org/maintainers you too ?
provinzkraut
approved these changes
Oct 3, 2025
…the reload option is enabled.
5b27f9a to
f48c78a
Compare
|
Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4352 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes
Closes #4329
Summary
When
--reloadis enabled, spawns uvicorn subprocess with a freshsys.path, which loses the--app-dirvalue. To preserve this value insys.path,--app-dirmust be explicitly passed to the uvicorn subprocess.Test plan
test_run_commandandtest_arguments_passedmight cover uvicorn parameter passing