Skip to content

fix: register new CLI commands with rich-click#4298

Merged
cofin merged 5 commits intomainfrom
cli-plugin-commands
Sep 21, 2025
Merged

fix: register new CLI commands with rich-click#4298
cofin merged 5 commits intomainfrom
cli-plugin-commands

Conversation

@cofin
Copy link
Copy Markdown
Member

@cofin cofin commented Sep 21, 2025

After the most recent updates to rich-click and click, CLI plugins no longer show the command in the command help text.

This is because the plugin was not loaded before rending the help text. This change ensures that the plugins are loaded prior to formatting the help output.

@cofin cofin requested review from a team as code owners September 21, 2025 15:24
@github-actions github-actions bot added area/private-api This PR involves changes to the privatized API size: small type/bug pr/internal labels Sep 21, 2025
@cofin cofin force-pushed the cli-plugin-commands branch from 5b4a521 to bba273e Compare September 21, 2025 15:26
@cofin cofin force-pushed the cli-plugin-commands branch from dea653e to 11050d8 Compare September 21, 2025 15:31
@cofin cofin enabled auto-merge (squash) September 21, 2025 15:32
@cofin cofin merged commit 980029f into main Sep 21, 2025
44 of 46 checks passed
@cofin cofin deleted the cli-plugin-commands branch September 21, 2025 15:48
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.25%. Comparing base (a5899b6) to head (11050d8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4298   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files         344      344           
  Lines       15866    15869    +3     
  Branches     1749     1749           
=======================================
+ Hits        15589    15592    +3     
  Misses        140      140           
  Partials      137      137           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4298

provinzkraut pushed a commit that referenced this pull request Sep 21, 2025
After the most recent updates to `rich-click` and `click`, CLI plugins no longer show the command in the command help text.

This is because the plugin was not loaded before rending the help text.  This change ensures that the plugins are loaded prior to formatting the help output.

(cherry picked from commit 980029f)
@dwreeves
Copy link
Copy Markdown
Contributor

dwreeves commented Oct 8, 2025

Sorry about that! 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/private-api This PR involves changes to the privatized API pr/internal size: small type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants