Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.93%. Comparing base (b105cff) to head (4d023c6).
⚠️ Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main    #4241   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         319      319           
  Lines       15583    15584    +1     
  Branches     1726     1726           
=======================================
+ Hits        15261    15262    +1     
  Misses        184      184           
  Partials      138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Hi! Is there any chance that this would be merged soon? Our team is currently experiencing an issue with the aud being an array. Or Maybe you know of any workaround to mitigate this issue without patching source code?

Hello @casabre , thanks for the PR! Could you please add a test case so we can go ahead and merge it?

@Harshal6927 @provinzkraut I added an own test for audience validation. Hope that works for you.

@provinzkraut I didn't change the imports but now pytest is complaining about a missing Sequence import during runtime. Actually, I don't know if this is related to a pytest version change and if I should fix the imports or leave it as it is...

@provinzkraut In the end, a missing import makes the pytests fail

FAILED tests/unit/test_security/test_jwt/test_auth.py::test_jwt_auth - NameError: name 'Sequence' is not defined

e.g. at https://github.com/litestar-org/litestar/actions/runs/17854788852/job/50771227842?pr=4241#step:10:9032

@provinzkraut I didn't change the imports but now pytest is complaining about a missing Sequence import during runtime. Actually, I don't know if this is related to a pytest version change and if I should fix the imports or leave it as it is...

Well it's because you are using Sequence but don't import it anywhere 😉

@provinzkraut I didn't change the imports but now pytest is complaining about a missing Sequence import during runtime. Actually, I don't know if this is related to a pytest version change and if I should fix the imports or leave it as it is...

Well it's because you are using Sequence but don't import it anywhere 😉

Yes, you right 😅. But I was relying on the correctness of previous logic --> because Sequence was used before my change I thus, I thought, it is covered. E.g here

It's not a problem for me to pull the collections import out of the type checking guard, but I am really wondering how it was working before 🤔

It's not a problem for me to pull the collections import out of the type checking guard, but I am really wondering how it was working before 🤔

The function signature is not validated during runtime. The dataclass itself is.

It's not a problem for me to pull the collections import out of the type checking guard, but I am really wondering how it was working before 🤔

The function signature is not validated during runtime. The dataclass itself is.

@provinzkraut Yes, I understand that but why was it failing now but before not, when Sequence was accessed too. Anyway... let't move ahead --> if you are satisfied with the change, can you just approve it 😊.

@provinzkraut what do you say to the changes? Can we move forward and merge?

Documentation preview will be available shortly at https://litestar-org.github.io/litestar-docs-preview/4241