Skip to content

Refactor benchmark yml#868

Merged
Kailai-Wang merged 10 commits intodevfrom
855-refactor-benchmark-yml
Oct 5, 2022
Merged

Refactor benchmark yml#868
Kailai-Wang merged 10 commits intodevfrom
855-refactor-benchmark-yml

Conversation

@Kailai-Wang
Copy link
Copy Markdown
Collaborator

resolves #855

This PR:

  • separates docker-build from actual benchmarking
  • use system and instance status check for reachability test

@Kailai-Wang Kailai-Wang self-assigned this Oct 4, 2022
Copy link
Copy Markdown
Collaborator

@BillyWooo BillyWooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #868 (7cb67cd) into dev (6442184) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #868   +/-   ##
=======================================
  Coverage   92.12%   92.12%           
=======================================
  Files          25       25           
  Lines        7071     7071           
=======================================
  Hits         6514     6514           
  Misses        557      557           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Kailai-Wang Kailai-Wang merged commit 1b4cec0 into dev Oct 5, 2022
@Kailai-Wang Kailai-Wang deleted the 855-refactor-benchmark-yml branch October 5, 2022 07:40
wangminqi added a commit that referenced this pull request Oct 11, 2022
* Types import and web3 signature verification for IMP mock (#850)

* update rust toolchain for llvm15

* add web3 verification skeleton

* implement verification

* fix ecdsa verify

* clippy fix and comments

* minor comment update

* debug: relocate migration file (#844)

* debug: relocate migration file

* debug: change runtime methpd
public to private

* debug: correct chain spec

* debug: correct chain spec

Co-authored-by: Kai <7630809+Kailai-Wang@users.noreply.github.com>

* Add tests for IMP mock (#856)

* remove MrenclaveType

* use oaep padding

* add more testcases

* add tests for verifying web3 identities

* clippy fix

* add cargofix

* add GHA for benchmarking machine (#870)

* Refactor benchmark yml (#868)

* separate docker-build and benchmark

* add if condition

* remove stop instance for debugging

* ssh debug

* retry

* more debugging

* go back to normal routine

* use reachability test for AWS instance

* fix syntax

* Initial VCMP impl (#857)

* move tee-related primitives to primitives/

* rename and use ALICE

* skeleton of vc-management pallet

* add basic tests

* minor comment update

* add vcmp to runtime

* cargo update

* cargo update

* use cargo pkgid for full-qualified pallet names

* add benchmark at bridge and bridge transfer pallet (#854)

* Fix some events triggered by token-bridge

* fix some syntax

* issue 794 add benchmark code

* fix benchmark code

* fix some syntax

* about benchmark code

* Chengcheng Shi

* fix some syntax

* add bridge-transfer weight file

* add benchmark code at bridge and bridge transfer pallet

* fix some syntax

* add benchmark code at litentry and litmus

* fix asset manager pallet benchmark code

* temporarily chose to comment pallet_collator_selection out

* Comment out the pallet_collator_selection module in the toml file

* fix parachain-staking benchmark code

* fix staking benchmark code

* fix staking benchmark code

* fix staking benchmark code

* fix all benchmarks code

* common the staking benchmark code

* fix some syntax

* commond the staking benchmarks

* common staking benchmarks

* fix syntax

* Temporarily comment out the staking benchmark

* Temporarily comment out the staking benchmark

* Temporarily comment out the staking benchmark

* separate docker-build and benchmark

* add if condition

* remove stop instance for debugging

* ssh debug

* retry

* more debugging

* go back to normal routine

* use reachability test for AWS instance

* fix syntax

* [benchmarking bot] Auto commit generated weights files (#869)

Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com>

* Change the bridge-related weight configuration in runtime

* fix bridge benchmark code

* [benchmarking bot] Auto commit generated weights files (#875)

Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com>

Co-authored-by: Chengcheng Shi <root@LAPTOP-73QQ3GCK.localdomain>
Co-authored-by: Kailai Wang <Kailai.Wang@hotmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com>
Co-authored-by: Kai <7630809+Kailai-Wang@users.noreply.github.com>

* Issue 871 Wrong weight calculation for acknowledge_proposal (#877)

* fix bridge benchmarks code

* fix some syntax

* [benchmarking bot] Auto commit generated weights files (#878)

Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com>

* Change how weight is calculated

* Change the weight

* [benchmarking bot] Auto commit generated weights files (#879)

Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com>

Co-authored-by: Chengcheng Shi <root@LAPTOP-73QQ3GCK.localdomain>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com>

* Bump serde_json from 1.0.85 to 1.0.86 (#882)

Bumps [serde_json](https://github.com/serde-rs/json) from 1.0.85 to 1.0.86.
- [Release notes](https://github.com/serde-rs/json/releases)
- [Commits](serde-rs/json@v1.0.85...v1.0.86)

---
updated-dependencies:
- dependency-name: serde_json
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add rococo for local dev (#880)

* bug fix about chain identity

* add CI/scripts for rococo

* add rococo ts-tests

* add --allow-fail to benchmark machine

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Kai <7630809+Kailai-Wang@users.noreply.github.com>
Co-authored-by: SCC <87012234+Jinsipang@users.noreply.github.com>
Co-authored-by: Chengcheng Shi <root@LAPTOP-73QQ3GCK.localdomain>
Co-authored-by: Kailai Wang <Kailai.Wang@hotmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jinsipang <Jinsipang@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate image building and benchmarking in GHA

3 participants