Fix minor typo in live directive paragraph#769
Merged
arthurevans merged 1 commit intolit:mainfrom May 9, 2022
Merged
Conversation
Contributor
|
Thanks for the catch! These pages are actually generated from the source code (current docs from the main branch, 1.x docs from the lit-html-1.x branch): https://github.com/lit/lit/blob/main/packages/lit-html/src/directives/live.ts#L86 Do you want to make PRs against the lit repo? If that's too much work, let me know. |
arthurevans
approved these changes
May 9, 2022
Contributor
|
Thanks for the fix! |
Merged
arthurevans
pushed a commit
to lit/lit
that referenced
this pull request
May 9, 2022
Fix is API doc only, error originally reported in lit/lit.dev#769.
arthurevans
pushed a commit
to lit/lit
that referenced
this pull request
May 10, 2022
Fix is API doc only, error originally reported in lit/lit.dev#769.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing a minor typo in the live directive description. Changed
againstoagainst.PS - When doing a search across files, I saw that there are two more instances of the typo (below). However, I wasn't sure how to rebuild these. I tried running
npm run buildfrom/packages/lit-dev-api/package.jsonbut it didn't seem to work. I can gladly update this PR if I can get some guidance on how to do so!/packages/lit-dev-api/api-data/lit-2/pages.json/packages/lit-dev-api/api-data/lit-html-1/pages.json