fix(lit-html): handle undefined arg on disconnect for ref directive #5218
Merged
Conversation
🦋 Changeset detectedLatest commit: c972037 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
louis-bompart
commented
Jan 30, 2026
| override update(part: ElementPart, [ref]: Parameters<this['render']>) { | ||
| const refChanged = ref !== this._ref; | ||
| if (refChanged && this._ref !== undefined) { | ||
| if (refChanged) { |
Contributor
Author
There was a problem hiding this comment.
Maybe an over-optimization, but we would have been checking twice whether this._ref is undefined in this code path.
Given that _updateRefValue handles it after my change, I removed this part of the condition.
sorvell
approved these changes
Feb 4, 2026
justinfagnani
approved these changes
Feb 12, 2026
augustjk
reviewed
Feb 12, 2026
kyubisation
pushed a commit
to kyubisation/lit
that referenced
this pull request
May 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
refis called withundefinedfor arg and the element where the ref has been render in disconnect, the disconnect method tried to callthis._ref.value, wherethis._refbeing undefined, causing an error.The
_updateRefValuemethod in essence currently already sieve thru the various type of the_refmember. This PR handles theundefinedcase by returning early.Fixes #5217