[labs/virtualizer] Trigger reflow after padding is set#3606
Merged
[labs/virtualizer] Trigger reflow after padding is set#3606
Conversation
🦋 Changeset detectedLatest commit: 9ec4bec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Hey @Westbrook thanks for the PR! To get this to pass the linter, can you run |
Contributor
|
@Westbrook sorry I didn't realize I could do that. Added changeset. |
usergenic
approved these changes
Jan 26, 2023
Contributor
usergenic
left a comment
There was a problem hiding this comment.
LGTM. We don't have very good tests around reflow behavior as such so I won't gate this on those, but I'll go to add them immediately after this comes in.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3285
Ensure that the layout for the Virtualizer is updated when a new
paddingvalue is provided.