-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Description
Which package(s) are affected?
Virtualizer (@lit-labs/virtualizer)
Description
The setter workflow for padding in SizeGapPaddingBaseLayout does not include calls to this._triggerReflow(); the way that the setter workflow for gap does, which prevents updates to the padding value of the layout from effecting layout until changes to something else in the calculation is updated.
Reproduction
Visit this demo
- See that `padding` and
gapare10pxeach - Click "Update `gap`" to see
gapchange - Click "Update `padding`" to see
paddingupdated but not effect the layout - Click "Update `padding`" until it reports a larger number, then click "Update `gap`" and see the layout finally update the "padding"
Workaround
Patch package works to just add a call to this._triggerReflow(); at the end of the padding setter, or only change both together.
Is this a regression?
No or unsure. This never worked, or I haven't tried before.
Affected versions
0.7.1
Browser/OS/Node environment
All browsers
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
✅ Done