[labs/virtualizer] Fix #3493 by graynorton · Pull Request #3525 · lit/lit

graynorton · 2022-12-15T00:35:41Z

changeset-bot · 2022-12-15T00:35:44Z

🦋 Changeset detected

Latest commit: aebf233

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@lit-labs/virtualizer	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2022-12-15T00:35:59Z

📊 Tachometer Benchmark Results

Summary

nop-update

lit-html-kitchen-sink: unsure 🔍 -2% - +3% (-0.40ms - +0.69ms)
^{this-change vs tip-of-tree}

render

lit-element-list: 83.75ms - 88.81ms
lit-html-kitchen-sink: unsure 🔍 -2% - +7% (-0.58ms - +2.34ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -6% - +4% (-0.71ms - +0.45ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -2% - +2% (-0.97ms - +1.08ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -2% - +4% (-0.84ms - +2.44ms)
^{this-change vs tip-of-tree}

update

lit-element-list: 772.54ms - 786.05ms
lit-html-kitchen-sink: unsure 🔍 -5% - +3% (-4.12ms - +2.55ms)
^{this-change vs tip-of-tree}
lit-html-repeat: unsure 🔍 -1% - +3% (-2.54ms - +8.03ms)
^{this-change vs tip-of-tree}
lit-html-template-heavy: unsure 🔍 -0% - +2% (-0.51ms - +1.87ms)
^{this-change vs tip-of-tree}
reactive-element-list: unsure 🔍 -1% - +1% (-5.79ms - +11.31ms)
^{this-change vs tip-of-tree}

update-reflect

lit-element-list: 770.02ms - 779.04ms
reactive-element-list: unsure 🔍 -1% - +1% (-8.46ms - +7.07ms)
^{this-change vs tip-of-tree}

Results

lit-element-list

Browser: chrome-headless 108.0.5359.94
Sample size: 50
Built by: Benchmarks #4197
Commit: f0867cb

render

Version	Avg time	vs
	83.75ms - 88.81ms	-

update

Version	Avg time	vs
	772.54ms - 786.05ms	-

update-reflect

Version	Avg time	vs
	770.02ms - 779.04ms	-

lit-html-kitchen-sink

Browser: chrome-headless 108.0.5359.94
Sample size: 30
Built by: Benchmarks #4197
Commit: f0867cb

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	31.11ms - 33.51ms	-	unsure 🔍 -2% - +7% -0.58ms - +2.34ms	unsure 🔍 -4% - +5% -1.25ms - +1.71ms
tip-of-tree tip-of-tree	30.60ms - 32.26ms	unsure 🔍 -7% - +2% -2.34ms - +0.58ms	-	unsure 🔍 -6% - +2% -1.84ms - +0.54ms
previous-release previous-release	31.22ms - 32.94ms	unsure 🔍 -5% - +4% -1.71ms - +1.25ms	unsure 🔍 -2% - +6% -0.54ms - +1.84ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	82.16ms - 86.00ms	-	unsure 🔍 -5% - +3% -4.12ms - +2.55ms	unsure 🔍 -3% - +3% -2.42ms - +2.43ms
tip-of-tree tip-of-tree	82.13ms - 87.59ms	unsure 🔍 -3% - +5% -2.55ms - +4.12ms	-	unsure 🔍 -3% - +5% -2.31ms - +3.90ms
previous-release previous-release	82.59ms - 85.55ms	unsure 🔍 -3% - +3% -2.43ms - +2.42ms	unsure 🔍 -5% - +3% -3.90ms - +2.31ms	-

nop-update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	22.37ms - 23.19ms	-	unsure 🔍 -2% - +3% -0.40ms - +0.69ms	unsure 🔍 -2% - +3% -0.48ms - +0.58ms
tip-of-tree tip-of-tree	22.28ms - 23.00ms	unsure 🔍 -3% - +2% -0.69ms - +0.40ms	-	unsure 🔍 -3% - +2% -0.59ms - +0.40ms
previous-release previous-release	22.40ms - 23.07ms	unsure 🔍 -3% - +2% -0.58ms - +0.48ms	unsure 🔍 -2% - +3% -0.40ms - +0.59ms	-

lit-html-repeat

Browser: chrome-headless 108.0.5359.94
Sample size: 30
Built by: Benchmarks #4197
Commit: f0867cb

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	11.46ms - 12.27ms	-	unsure 🔍 -6% - +4% -0.71ms - +0.45ms	unsure 🔍 -6% - +3% -0.72ms - +0.41ms
tip-of-tree tip-of-tree	11.59ms - 12.41ms	unsure 🔍 -4% - +6% -0.45ms - +0.71ms	-	unsure 🔍 -5% - +5% -0.60ms - +0.54ms
previous-release previous-release	11.63ms - 12.42ms	unsure 🔍 -4% - +6% -0.41ms - +0.72ms	unsure 🔍 -5% - +5% -0.54ms - +0.60ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	302.77ms - 311.37ms	-	unsure 🔍 -1% - +3% -2.54ms - +8.03ms	unsure 🔍 -1% - +3% -2.29ms - +8.83ms
tip-of-tree tip-of-tree	301.24ms - 307.40ms	unsure 🔍 -3% - +1% -8.03ms - +2.54ms	-	unsure 🔍 -1% - +2% -4.16ms - +5.21ms
previous-release previous-release	300.26ms - 307.33ms	unsure 🔍 -3% - +1% -8.83ms - +2.29ms	unsure 🔍 -2% - +1% -5.21ms - +4.16ms	-

lit-html-template-heavy

Browser: chrome-headless 108.0.5359.94
Sample size: 50
Built by: Benchmarks #4197
Commit: f0867cb

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	54.23ms - 55.40ms	-	unsure 🔍 -2% - +2% -0.97ms - +1.08ms	unsure 🔍 -1% - +3% -0.57ms - +1.36ms
tip-of-tree tip-of-tree	53.92ms - 55.59ms	unsure 🔍 -2% - +2% -1.08ms - +0.97ms	-	unsure 🔍 -1% - +3% -0.80ms - +1.47ms
previous-release previous-release	53.65ms - 55.18ms	unsure 🔍 -2% - +1% -1.36ms - +0.57ms	unsure 🔍 -3% - +1% -1.47ms - +0.80ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	113.84ms - 115.40ms	-	unsure 🔍 -0% - +2% -0.51ms - +1.87ms	unsure 🔍 -1% - +1% -0.84ms - +1.50ms
tip-of-tree tip-of-tree	113.04ms - 114.84ms	unsure 🔍 -2% - +0% -1.87ms - +0.51ms	-	unsure 🔍 -1% - +1% -1.60ms - +0.90ms
previous-release previous-release	113.42ms - 115.16ms	unsure 🔍 -1% - +1% -1.50ms - +0.84ms	unsure 🔍 -1% - +1% -0.90ms - +1.60ms	-

reactive-element-list

Browser: chrome-headless 108.0.5359.94
Sample size: 50
Built by: Benchmarks #4197
Commit: f0867cb

render

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	54.23ms - 56.57ms	-	unsure 🔍 -2% - +4% -0.84ms - +2.44ms	unsure 🔍 -3% - +3% -1.71ms - +1.54ms
tip-of-tree tip-of-tree	53.46ms - 55.75ms	unsure 🔍 -4% - +1% -2.44ms - +0.84ms	-	unsure 🔍 -4% - +1% -2.49ms - +0.72ms
previous-release previous-release	54.36ms - 56.61ms	unsure 🔍 -3% - +3% -1.54ms - +1.71ms	unsure 🔍 -1% - +5% -0.72ms - +2.49ms	-

update

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	789.60ms - 801.92ms	-	unsure 🔍 -1% - +1% -5.79ms - +11.31ms	unsure 🔍 -1% - +1% -7.43ms - +9.00ms
tip-of-tree tip-of-tree	787.07ms - 798.93ms	unsure 🔍 -1% - +1% -11.31ms - +5.79ms	-	unsure 🔍 -1% - +1% -10.02ms - +6.07ms
previous-release previous-release	789.54ms - 800.41ms	unsure 🔍 -1% - +1% -9.00ms - +7.43ms	unsure 🔍 -1% - +1% -6.07ms - +10.02ms	-

update-reflect

Version	Avg time	vs this-change	vs tip-of-tree tip-of-tree	vs previous-release previous-release
this-change	810.27ms - 821.14ms	-	unsure 🔍 -1% - +1% -8.46ms - +7.07ms	unsure 🔍 -1% - +1% -9.27ms - +5.99ms
tip-of-tree tip-of-tree	810.86ms - 821.95ms	unsure 🔍 -1% - +1% -7.07ms - +8.46ms	-	unsure 🔍 -1% - +1% -8.66ms - +6.77ms
previous-release previous-release	811.99ms - 822.71ms	unsure 🔍 -1% - +1% -5.99ms - +9.27ms	unsure 🔍 -1% - +1% -6.77ms - +8.66ms	-

_{tachometer-reporter-action v2 for Benchmarks}

usergenic

LGTM! Thanks for the test cases @graynorton

@Westbrook

* add test for lit#3493 * fix lit#3493 (thanks, @Westbrook)

Gray Norton added 2 commits December 14, 2022 16:32

add test for #3493

cceb52a

fix #3493 (thanks, @Westbrook)

aebf233

graynorton requested a review from usergenic December 15, 2022 00:35

graynorton requested a review from justinfagnani as a code owner December 15, 2022 00:35

graynorton mentioned this pull request Dec 15, 2022

[labs/virtualizer] Accept assigned slots as parent elements #3494

Closed

usergenic approved these changes Dec 15, 2022

View reviewed changes

graynorton merged commit 0b67553 into main Dec 15, 2022

graynorton deleted the fix-3493 branch December 15, 2022 00:51

This was referenced Dec 15, 2022

Version Packages #3528

Closed

Version Packages #3531

Merged

43081j pushed a commit to 43081j/lit-html that referenced this pull request Jan 4, 2023

[labs/virtualizer] Fix lit#3493 (lit#3525)

36ce5d1

* add test for lit#3493 * fix lit#3493 (thanks, @Westbrook)

Conversation

graynorton commented Dec 15, 2022

Uh oh!

changeset-bot bot commented Dec 15, 2022

🦋 Changeset detected

Uh oh!

github-actions bot commented Dec 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Tachometer Benchmark Results

Summary

nop-update

render

update

update-reflect

Results

render

update

update-reflect

render

update

nop-update

render

update

render

update

render

update

update-reflect

Uh oh!

usergenic left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Dec 15, 2022 •

edited

Loading