Fix test target to propagate exit code on failure#171
Merged
Conversation
The pipe in `make test` caused go test's exit code to be swallowed, so CI would pass even when tests failed. Remove -v flag and pipe to simplify output and correctly propagate the exit code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Code Metrics Report
Details | | main (fd5141b) | #171 (a7234de) | +/- |
|---------------------|----------------|----------------|------|
| Coverage | 55.9% | 55.9% | 0.0% |
| Files | 65 | 65 | 0 |
| Lines | 6553 | 6553 | 0 |
| Covered | 3666 | 3666 | 0 |
| Code to Test Ratio | 1:1.0 | 1:1.0 | 0.0 |
| Code | 12848 | 12848 | 0 |
| Test | 13267 | 13267 | 0 |
- | Test Execution Time | 24s | 1m23s | +59s |Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make testcausedgo test's exit code to be swallowed by the lastsedcommand, so CI would pass even when tests failed-vflag and pipe (grep/sed) so thatgo test's exit code propagates correctlyTest plan
make test🤖 Generated with Claude Code