Conversation
Use chromedp.DefaultExecAllocatorOptions as the base for Chrome launch options instead of manually specifying a subset. This ensures all recommended flags (disable-extensions, enable-automation, etc.) are included, preventing Chrome from hanging during startup on CI. Also add WSURLReadTimeout to match the user-specified timeout instead of relying on the 20-second default, and pin setup-chrome action to a specific SHA to prevent unexpected Chrome version updates. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
1 similar comment
Code Metrics Report
Details | | main (b8c517b) | #167 (5745065) | +/- |
|---------------------|----------------|----------------|-------|
+ | Coverage | 56.0% | 56.0% | +0.0% |
| Files | 65 | 65 | 0 |
| Lines | 6578 | 6579 | +1 |
+ | Covered | 3685 | 3686 | +1 |
+ | Code to Test Ratio | 1:1.0 | 1:1.0 | +0.0 |
| Code | 12892 | 12888 | -4 |
| Test | 13269 | 13269 | 0 |
- | Test Execution Time | 21s | 26s | +5s |Code coverage of files in pull request scope (46.9% → 47.3%)
Reported by octocov |
Owner
Author
|
/run-e2e |
|
✅ E2E test passed successfully! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browser/client.go: Usechromedp.DefaultExecAllocatorOptionsas the base for Chrome launch options instead of manually specifying a subset. This ensures all recommended flags (--disable-extensions,--enable-automation,--disable-sync, etc.) are included, preventing Chrome from hanging during startup on CI.browser/client.go: Addchromedp.WSURLReadTimeoutto match the user-specified timeout (e.g.1m) instead of relying on chromedp's 20-second default, which was causing premature "websocket url timeout reached" errors..github/workflows/end-to-end-test.yml: Pinbrowser-actions/setup-chrometo a specific SHA to prevent unexpected Chrome version updates from breaking CI.Test plan
go build ./...passesgo test ./...passes (all packages)go test ./browser/...passes🤖 Generated with Claude Code