Add SSH E2E test with container-based approach#143
Merged
Conversation
- Add SSH server container test using linuxserver/openssh-server - Generate SSH key pair for testing with public key authentication - Add cleanup steps for all containers (HTTP, PostgreSQL, MySQL, SSH) - Update examples/ssh.yml to support SSH_KEY_FILE environment variable - Fix examples/shell.yml workdir test to avoid /tmp race conditions - Add testdata/ssh to .gitignore for generated test keys Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
When strict_host_check is false, known_hosts file is not needed. This was causing CI failures when the file doesn't exist. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Code Metrics Report
Details | | main (dcea44c) | #143 (034e96f) | +/- |
|---------------------|----------------|----------------|-------|
- | Coverage | 48.5% | 48.5% | -0.1% |
| Files | 52 | 52 | 0 |
| Lines | 5244 | 5244 | 0 |
- | Covered | 2547 | 2546 | -1 |
| Code to Test Ratio | 1:1.1 | 1:1.1 | 0.0 |
| Code | 10564 | 10564 | 0 |
| Test | 11955 | 11955 | 0 |
+ | Test Execution Time | 29s | 24s | -5s |Code coverage of files in pull request scope (73.1% → 72.0%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
testdata/verify-examples.yml
examples/ssh.yml
examples/shell.yml
.gitignore
Test Plan
Run the E2E tests:
All SSH tests should pass with container-based SSH server.
🤖 Generated with Claude Code