Display dependency-failed jobs as skipped (grayed out)#142
Merged
Conversation
Jobs that cannot run due to failed dependencies are now displayed as SKIPPED (grayed out) in the report, similar to jobs skipped by skipif conditions. Changes: - workflow.go: Changed Status from "Skipped" to "skipped" (lowercase) to match skipif behavior - workflow.go: Set Success=true for skipped jobs, so they don't count as failures in the final report This provides a clearer distinction between: - Jobs that actually failed (counted as failures) - Jobs that were skipped due to failed dependencies (not counted) Example output: ⏺ 3rd job (Failed in 0.02s) ⏺ 4th job (SKIPPED) <- grayed out ⏺ 5th job (SKIPPED) <- grayed out Total: ✗ 1 job(s) failed (not 3) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Code Metrics Report
Details | | main (9938fa9) | #142 (d67a816) | +/- |
|---------------------|----------------|----------------|-------|
+ | Coverage | 48.5% | 48.5% | +0.0% |
| Files | 52 | 52 | 0 |
| Lines | 5244 | 5244 | 0 |
+ | Covered | 2546 | 2547 | +1 |
| Code to Test Ratio | 1:1.1 | 1:1.1 | 0.0 |
| Code | 10564 | 10564 | 0 |
| Test | 11955 | 11955 | 0 |
- | Test Execution Time | 20s | 23s | +3s |Code coverage of files in pull request scope (70.1% → 70.6%)
Reported by octocov |
1 similar comment
Code Metrics Report
Details | | main (9938fa9) | #142 (d67a816) | +/- |
|---------------------|----------------|----------------|-------|
+ | Coverage | 48.5% | 48.5% | +0.0% |
| Files | 52 | 52 | 0 |
| Lines | 5244 | 5244 | 0 |
+ | Covered | 2546 | 2547 | +1 |
| Code to Test Ratio | 1:1.1 | 1:1.1 | 0.0 |
| Code | 10564 | 10564 | 0 |
| Test | 11955 | 11955 | 0 |
- | Test Execution Time | 20s | 23s | +3s |Code coverage of files in pull request scope (70.1% → 70.6%)
Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Jobs that cannot run due to failed dependencies are now displayed as SKIPPED (grayed out) in the report, matching the behavior of jobs skipped by
skipifconditions.Problem
When jobs were skipped due to failed dependencies:
skipifbehavior, which shows jobs as grayed outExample before:
Solution
Changed the status of dependency-failed jobs from "Skipped" (capitalized) to "skipped" (lowercase) to match the existing printer logic for skipif conditions.
Also set
Success=truefor these jobs so they don't count as failures.Changes
jr.Status = "Skipped"→"skipped"(lowercase)jr.Success = false→trueResult
Example after:
This provides a clearer distinction between:
Test Plan
examples/needs-literal.yml(5-level dependency chain)🤖 Generated with Claude Code