I’ve noticed that while this fix works in most cases, there are rare situations where clicking the sound icon doesn’t unmute as expected. I’m still trying to identify the exact trigger, but wanted to flag it here so reviewers are aware

Hi @mtwebster , just wondering if this fix is valid and if there’s any feedback I should take into account. I’d really like to understand if I’m approaching this the right way, so I can improve my future contributions. Thanks!

Hi, this looks ok - it appears the original behavior is due to the fact that you're clicking on the left end of the slider widget. The way the slider popup 'widget' is implemented, any click on that row is fed to the slider itself. And in this case, with the volume all the way down, the muted icon is used. So we're not really muting here, just turning the volume 'off'.

Even with your fix, if you're just a tiny bit off that icon, the underlying handler can still get the event (and make the volume 'off' rather than just 'muted')

I'm going to fix the implementation for the slider itself, so only clicks on the visible slider part will affect its position. This should make your icon handler more reliable.

One thing to note, actors are reactive by default (you didn't have to explicitly set it - no big deal).