Remove dead code in lib/, port libltp to FreeBSD, and port some testcases to FreeBSD #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 2, 2014 19:55
- Use setpgid instead of setpgrp - Add *BSD support - Mute some -Wuninitialized warnings - Mute some clang warnings - Add a simple script for printing out the overall run summary Sponsored-by: EMC / Isilon Storage Division
I'm not as pedantic as I was before Signed-off-by: Garrett Cooper <yanegomi@gmail.com>
This involved... - Muting a clang warnings - Removing #includes to malloc.h - Stubbing out Linux-specific pieces. - Stubbing out memalign (it's an obsolete Linux syscall) - Fix typecasting in va_arg in safe_open function to mute clang warnings - Use SIGCHLD instead of SIGCLD for portability reasons - Port errnos.h to FreeBSD - Remove sys/sysmacros.h (it was unused) - Port tst_resm to portable pthreads Signed-off-by: Garrett Cooper <yanegomi@gmail.com> Sponsored-by: EMC / Isilon Storage Division
Sponsored-by: EMC / Isilon Storage Division Signed-off-by: Garrett Cooper <yanegomi@gmail.com>
added 15 commits
July 9, 2014 13:32
Signed-off-by: Garrett Cooper <yanegomi@gmail.com>
Port K&R function declarations to something non-K&R like Sponsored-by: EMC / Isilon Storage Division
Add an "assert" to make sure that the value is good at least once Sponsored-by: EMC / Isilon Storage Division
Sponsored-by: EMC / Isilon Storage Division
Sponsored-by: EMC / Isilon Storage Division
Automatically determine whether or not one is running Linux by whether or not __linux__ is defined via the compiler Sponsored-by: EMC / Isilon Storage Division
Sponsored-by: EMC / Isilon Storage Division
…pliant code Sponsored-by: EMC / Isilon Storage Division
Sponsored-by: EMC / Isilon Storage Division
Convert the value to a long to get past a clang warning Sponsored-by: EMC / Isilon Storage Division
Sponsored-by: EMC / Isilon Storage Division
Sponsored-by: EMC / Isilon Storage Division
Sponsored-by: EMC / Isilon Storage Division
….h for strerror Sponsored-by: EMC / Isilon Storage Division
Sponsored-by: EMC / Isilon Storage Division
Sponsored-by: EMC / Isilon Storage Division
Member
|
These are more complicated changes than the last trivial ones it would be better to send them to the mailing list as well because it's still primary place for patch review. |
Member
|
What is the status of this pull request. I've looked at the patches but they are quite messy, some does not apply to LTP git HEAD, some partially reverts changes introduced by previous patches. Should I close the pull request? Are you planning on cleaning up the patches so that they are applicable? |
|
Please don't close this issue, I'm going to rebase the changes to HEAD. My platform is NetBSD-current. |
Member
|
There was no real work done on this for 2014, closing. |
jstancek
added a commit
that referenced
this pull request
May 22, 2017
Only newlib testcases support SAFE macros in cleanup(). When SAFE_UNLINK fails, it creates infinite loop between tst_brk_ and cleanup: #0 tst_res__ at tst_res.c:153 #1 0x0000000000407ba8 in tst_brk__ at tst_res.c:480 #2 0x00000000004081fe in tst_brkm_ at tst_res.c:577 #3 0x000000000040a7c9 in safe_unlink at safe_macros.c:358 #4 0x0000000000404abd in cleanup () at pipeio.c:497 #5 0x0000000000407bc7 in tst_brk__ at tst_res.c:498 #6 0x00000000004081fe in tst_brkm_ at tst_res.c:577 #7 0x000000000040c1d6 in def_handler at tst_sig.c:231 #8 <signal handler called> #9 0x00007f29c2cbd1f7 in __GI_raise at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #10 0x00007f29c2cbe8e8 in __GI_abort () at abort.c:90 #11 0x00000000004081af in tst_brkm_ at tst_res.c:581 #12 0x000000000040a7c9 in safe_unlink at safe_macros.c:358 #13 0x0000000000404abd in cleanup () at pipeio.c:497 #14 0x0000000000407bc7 in tst_brk__ at tst_res.c:498 #15 0x00000000004081fe in tst_brkm_ at tst_res.c:577 #16 0x000000000040c1d6 in def_handler at tst_sig.c:231 #17 <signal handler called> #18 0x00007f29c2cbd1f7 in __GI_raise at ../nptl/sysdeps/unix/sysv/linux/raise.c:56 #19 0x00007f29c2cbe8e8 in __GI_abort () at abort.c:90 #20 0x00000000004081af in tst_brkm_ at tst_res.c:581 #21 0x000000000040a7c9 in safe_unlink at safe_macros.c:358 #22 0x0000000000404abd in cleanup () at pipeio.c:497 ... Signed-off-by: Jan Stancek <jstancek@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to be compiled against Linux and tested.
Sponsored-by: EMC / Isilon Storage Division
Signed-off-by: Garrett Cooper yanegomi@gmail.com