Merged
Conversation
or greater needed to include ParseError definition (see https://github.com/dateutil/dateutil/releases/tag/2.8.1). Code breaks in projects using LinkML if they don't have the latest module dependency imported..
Member
|
would be great to add a test to ensure bad behavior does't regress - but I'm happy to merge this now if this is an urgent fix |
Member
|
@RichardBruskiewich: apologies for modifying your branch directly. Do let me know if you think it's better for 1b1a940 to sit in its own PR, and then merged into your branch. But the commit basically addresses @cmungall's comment about adding a test to ensure that the bad behaviour doesn't regress. |
sujaypatil96
approved these changes
Dec 1, 2021
Contributor
Author
Totally fine @sujaypatil96 ! |
kevinschaper
pushed a commit
that referenced
this pull request
Oct 27, 2025
…t_args schemaview.py: allow `detect_cycles` to receive a list of nodes as args
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
or greater needed to include ParseError definition (see https://github.com/dateutil/dateutil/releases/tag/2.8.1). Code breaks in projects using LinkML if they don't have the latest module dependency imported..