[feature] add support for dropdowns based on enums in schema#422
Merged
sujaypatil96 merged 3 commits intomainfrom Oct 21, 2021
Merged
[feature] add support for dropdowns based on enums in schema#422sujaypatil96 merged 3 commits intomainfrom
sujaypatil96 merged 3 commits intomainfrom
Conversation
Member
Author
|
This PR is ready for review. The excel sheet that is generated by running the following command: is attached here: personinfo_excelgen_0.0.1.xlsx Please check the |
Member
|
I got into a spot of bother:
It seems to happen as FamilialRelationship_type is offered as a dropdown But I think this is good enough to merge |
cmungall
approved these changes
Oct 21, 2021
Member
Author
|
Hm, I'm not sure not sure what operation is causing that error, are you copying some text? From the above image you can see it's showing all the respective options for a particular slot. If you try typing something in the cells other than the drop down values, it'll give you a warning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is still a work in progress. It seeks to add drop down support to the Excel sheet generated by
gen-excelbased on the enums specified in the LinkML schema.I have split up the PR into 4 tasks:
visit_enumand store the data in an appropriate data structurevisit_class_slotso you know what slots to apply the drop downs to