Fix bug in sqlddlgen where an incorrect variable was being referenced#419
Merged
cmungall merged 1 commit intolinkml:mainfrom Oct 18, 2021
Merged
Fix bug in sqlddlgen where an incorrect variable was being referenced#419cmungall merged 1 commit intolinkml:mainfrom
cmungall merged 1 commit intolinkml:mainfrom
Conversation
cmungall
approved these changes
Oct 18, 2021
cmungall
approved these changes
Oct 18, 2021
Member
cmungall
left a comment
There was a problem hiding this comment.
Thanks! Noticed by @joeflack4 12 days ago but we didn't get around to making a ticket #366 (comment)
iQuxLE
pushed a commit
that referenced
this pull request
Aug 18, 2025
SchemaView: linter fixes, minor code reorganisation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug originating from a single line where an undefined variable was being referenced when creating a table for a class that had no slots. The intended effect is for linkml to just provide a warning instead of failing with
undefined variable referenced before assignment.