Closed
Conversation
cmungall
requested changes
Oct 18, 2021
Member
cmungall
left a comment
There was a problem hiding this comment.
Let me check I understand - does this have the effect of locking versions for every application that uses linkml? That isn't desirable. E.g. we will block people from using click 7.1.3 or jinja 3.0.3 etc
Member
Author
|
I can see in the requirements.txt and requirements-dev.txt files that where it says in the comments that the requirements files have been automatically generated using The commands that freeze out the requirements using The requirements files that are in this PR have been generated using the above commands. If we don't want to use them, I'm happy to remove them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seeks address issue #76. The following points are the highlight of the PR:
pipenvis used only by package developer or contributors to install the package locally for testing purposespipto install the package from PyPI as detailed in the docsrequirements.txtandrequirements-dev.txt. These files have been generated usingpipenvand notpip