Javagen abstract 2: The Abstractening#407
Merged
kevinschaper merged 8 commits intomainfrom Oct 15, 2021
Merged
Conversation
cmungall
reviewed
Oct 14, 2021
| @Data | ||
| @EqualsAndHashCode(callSuper=false) | ||
| public class Relationship { | ||
| public class Relationship { |
Member
There was a problem hiding this comment.
oops, minor but annoying issue. You have to tweak the magic - in jinja2
cmungall
approved these changes
Oct 14, 2021
iQuxLE
pushed a commit
that referenced
this pull request
Aug 18, 2025
SchemaView remote import bug fix prep: test reorganisation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I recently hit the same test artifact explosion and have a little practice, I cherry picked @sierra-moxon's changes from #403 to make a clean PR.
I think we could probably shift to writing something closer to unit tests on the OOCodeGen & JavaGenerator code rather than an integration test on the actual output, but it might make more sense to tackle that in #395, since it seems like a more complex scenario.