Skip to content

outbound: Simplify discovery debug logging#2316

Merged
olix0r merged 1 commit intomainfrom
ver/debugroutes
Mar 13, 2023
Merged

outbound: Simplify discovery debug logging#2316
olix0r merged 1 commit intomainfrom
ver/debugroutes

Conversation

@olix0r
Copy link
Member

@olix0r olix0r commented Mar 13, 2023

  • Reduce verbosity of per-request route debug logging
  • Increase profile resolution logging to debug

* Reduce verbosity of per-request route debug logging
* Increase profile resolution logging to debug
@olix0r olix0r requested a review from a team as a code owner March 13, 2023 23:02
@olix0r olix0r merged commit 5aea948 into main Mar 13, 2023
@olix0r olix0r deleted the ver/debugroutes branch March 13, 2023 23:14
hawkw added a commit to linkerd/linkerd2 that referenced this pull request Mar 15, 2023
This proxy release changes the multicluster gateway to discover Gateway
API routes via the `OutboundPolicy` API. This builds on the similar
changes to the outbound proxy in v2.192.

---

* gateway: discover client policies from the policy controller (linkerd/linkerd2-proxy#2315)
* build(deps): bump windows_x86_64_msvc from 0.42.1 to 0.42.2 (linkerd/linkerd2-proxy#2319)
* build(deps): bump proc-macro2 from 1.0.51 to 1.0.52 (linkerd/linkerd2-proxy#2320)
* outbound: Apply filters to outbound requests (linkerd/linkerd2-proxy#2260)
* test: add mock client policy resolver (linkerd/linkerd2-proxy#2314)
* build(deps): bump tj-actions/changed-files from 35.6.4 to 35.7.0 (linkerd/linkerd2-proxy#2318)
* build(deps): bump axum from 0.6.10 to 0.6.11 (linkerd/linkerd2-proxy#2321)
* build(deps): bump ryu from 1.0.12 to 1.0.13 (linkerd/linkerd2-proxy#2322)
* build(deps): bump windows_x86_64_gnullvm from 0.42.1 to 0.42.2 (linkerd/linkerd2-proxy#2323)
* outbound: Eagerly cancel synthesized profile task (linkerd/linkerd2-proxy#2317)
* outbound: Simplify discovery debug logging (linkerd/linkerd2-proxy#2316)
* build(deps): bump tj-actions/changed-files from 35.6.1 to 35.6.4 (linkerd/linkerd2-proxy#2309)
olix0r added a commit to linkerd/linkerd2 that referenced this pull request Mar 21, 2023
* proxy: v2.193.0

This proxy release changes the multicluster gateway to discover Gateway
API routes via the `OutboundPolicy` API. This builds on the similar
changes to the outbound proxy in v2.192.

---

* gateway: discover client policies from the policy controller (linkerd/linkerd2-proxy#2315)
* build(deps): bump windows_x86_64_msvc from 0.42.1 to 0.42.2 (linkerd/linkerd2-proxy#2319)
* build(deps): bump proc-macro2 from 1.0.51 to 1.0.52 (linkerd/linkerd2-proxy#2320)
* outbound: Apply filters to outbound requests (linkerd/linkerd2-proxy#2260)
* test: add mock client policy resolver (linkerd/linkerd2-proxy#2314)
* build(deps): bump tj-actions/changed-files from 35.6.4 to 35.7.0 (linkerd/linkerd2-proxy#2318)
* build(deps): bump axum from 0.6.10 to 0.6.11 (linkerd/linkerd2-proxy#2321)
* build(deps): bump ryu from 1.0.12 to 1.0.13 (linkerd/linkerd2-proxy#2322)
* build(deps): bump windows_x86_64_gnullvm from 0.42.1 to 0.42.2 (linkerd/linkerd2-proxy#2323)
* outbound: Eagerly cancel synthesized profile task (linkerd/linkerd2-proxy#2317)
* outbound: Simplify discovery debug logging (linkerd/linkerd2-proxy#2316)
* build(deps): bump tj-actions/changed-files from 35.6.1 to 35.6.4 (linkerd/linkerd2-proxy#2309)

* proxy: v2.193.1

* outbound: fix `Balance::Dispatch` "authority" labels (linkerd/linkerd2-proxy#2332)
* outbound: refactor `discover::resolver` into a method (linkerd/linkerd2-proxy#2331)

* proxy: v2.193.2

Both outbound and gateway proxies now resolve client policies from the
OutboundPolicies API. When the outbound proxy attempts to discover a
policy and the policy controller returns NotFound, it synthesizes a
default policy from the discovered ServiceProfile. However, when the
gateway proxy receives a NotFound, it will currently fail the
connection, based on the assumption that only valid cluster DNS names
are gatewayed (and not arbitrary IPs that might be forwards).
Unfortunately, this is not quite true. Gateway proxies may attempt to
discover cluster DNS names that are Pod DNS names, rather than Service
DNS names, and the policy controller will return NotFound for those
names.

This branch therefore changes the gateway proxy to also synthesize
default ClientPolicies based on the ServiceProfile when receiving a
NotFound status. Some of the code for synthesizing a client policy
from a ServiceProfile that's currently used in the outbound proxy was
factored out so that it could be reused here.

---

* gateway: move discovery resolver into its own file (linkerd/linkerd2-proxy#2343)
* outbound: Fix incorrect l5d-proxy-connection logs (linkerd/linkerd2-proxy#2344)
* gateway: synthesize ClientPolicies when the controller returns `NotFound` (linkerd/linkerd2-proxy#2333)

Signed-off-by: Oliver Gould <ver@buoyant.io>

---------

Signed-off-by: Oliver Gould <ver@buoyant.io>
Co-authored-by: Oliver Gould <ver@buoyant.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant