rename OpaqueTransport to TaggedTransport#2212
Closed
hawkw wants to merge 7 commits intoeliza/9888from
Closed
Conversation
olix0r
added a commit
that referenced
this pull request
Feb 13, 2023
From #2212 Co-authored-by: Eliza Weisman <eliza@buoyant.io>
olix0r
added a commit
that referenced
this pull request
Feb 13, 2023
We differentiate "opaque" and "tcp" stacks because some TCP stacks may
also apply for HTTP traffic. We shorten this in code as "opaq" because
it's unambiguous and the same length as "http"
* Add an `outbound::opaq` module for opaque stacks. ("opaq").
* Rename `push_tcp_{logical,concrete,forward}` to `push_opaq_*`
* Rename `OpaqueTransport` to `TaggedTransport` (Closes #2212).
Member
|
This PR is stale, but this change is included in #2224 |
olix0r
added a commit
that referenced
this pull request
Feb 13, 2023
We differentiate "opaque" and "tcp" stacks because some TCP stacks may
also apply for HTTP traffic. We shorten this in code as "opaq" because
it's unambiguous and the same length as "http"
* Add an `outbound::opaq` module for opaque stacks. ("opaq").
* Rename `push_tcp_{logical,concrete,forward}` to `push_opaq_*`
* Rename `OpaqueTransport` to `TaggedTransport` (Closes #2212).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #2209
The "opaque transport" feature is somewhat confusingly named. This
feature refers to a system where the outbound proxy makes a direct
connection to the inbound proxy's inbound port, and sends a
TransportHeadercontaining the actual target port, along with anoptional authority and protocol hint. This feature can be used to
transport actually opaque protocols, but it is also used by
multicluster gateways to transport HTTP traffic non-opaquely. Therefore,
the name "opaque transport" is somewhat confusing here.
This branch renames the "opaque transport" middleware to "tagged
transport", which is (hopefully) somewhat clearer, as it no longer
suggests that this form of tagging inherently means that no
protocol-aware behavior is performed.